Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support upgrade/patch offline tidb/dm cluster #1096

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Jan 25, 2021

What problem does this PR solve?

Fix #1027
Fix #563
Fix #523
Fix #1199

What is changed and how it works?

Support --offline flag for:

  • tiup cluster upgrade
  • tiup dm upgrade
  • tiup cluster patch
  • tiup dm upgrade

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@lucklove lucklove added the status/need-doc Indicates that we should update document before merge a PR. label Jan 25, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 25, 2021
@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #1096 (d9ff5c1) into master (8fb48a6) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1096      +/-   ##
==========================================
- Coverage   56.66%   56.63%   -0.04%     
==========================================
  Files         283      283              
  Lines       20025    20035      +10     
==========================================
- Hits        11347    11346       -1     
- Misses       6928     6935       +7     
- Partials     1750     1754       +4     
Flag Coverage Δ
cluster 45.18% <81.81%> (+<0.01%) ⬆️
dm 24.85% <54.54%> (-0.09%) ⬇️
integrate 51.10% <83.33%> (-0.04%) ⬇️
playground 20.91% <ø> (ø)
tiup 16.37% <ø> (ø)
unittest 22.73% <55.55%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/upgrade.go 62.06% <0.00%> (-1.41%) ⬇️
components/dm/command/patch.go 55.00% <75.00%> (+5.00%) ⬆️
components/cluster/command/patch.go 72.72% <100.00%> (+2.72%) ⬆️
components/cluster/command/upgrade.go 77.77% <100.00%> (+2.77%) ⬆️
components/dm/command/upgrade.go 77.77% <100.00%> (+6.34%) ⬆️
pkg/cluster/manager/patch.go 49.45% <100.00%> (+0.56%) ⬆️
pkg/cluster/api/dmapi.go 58.26% <0.00%> (-4.35%) ⬇️
pkg/cluster/manager/display.go 81.94% <0.00%> (-1.39%) ⬇️
components/dm/spec/topology_dm.go 82.40% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb48a6...d9ff5c1. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 1, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d9ff5c1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 1, 2021
@ti-chi-bot
Copy link
Member

@lucklove: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d90ee6a into pingcap:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/need-doc Indicates that we should update document before merge a PR.
Projects
None yet
4 participants