Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add darwin-arm64 not support hint for install.sh #1123

Merged
merged 3 commits into from
Feb 2, 2021

Conversation

terasum
Copy link
Contributor

@terasum terasum commented Feb 2, 2021

The darwin-arm64 is not supported currently, and add some friendly hint.

What problem does this PR solve?

temporary fix for #1122

What is changed and how it works?

Add some hints

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

The darwin-arm64 is not supported currently, and add some friendly hint.
@CLAassistant
Copy link

CLAassistant commented Feb 2, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2021
@codecov-io
Copy link

codecov-io commented Feb 2, 2021

Codecov Report

Merging #1123 (c22495a) into master (dc3a20e) will decrease coverage by 21.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1123       +/-   ##
===========================================
- Coverage   56.63%   34.87%   -21.76%     
===========================================
  Files         285      269       -16     
  Lines       20200    19527      -673     
===========================================
- Hits        11441     6811     -4630     
- Misses       6997    11655     +4658     
+ Partials     1762     1061      -701     
Flag Coverage Δ
cluster 27.26% <ø> (-17.78%) ⬇️
dm ?
integrate 27.26% <ø> (-23.78%) ⬇️
playground ?
tiup ?
unittest 22.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/template/install/local_install.sh.go 0.00% <ø> (ø)
main.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/main.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/bindversion.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/cluster.go 0.00% <0.00%> (-87.50%) ⬇️
components/playground/monitor.go 0.00% <0.00%> (-84.42%) ⬇️
pkg/queue/any_queue.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/cluster/manager/display.go 0.00% <0.00%> (-83.34%) ⬇️
... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc3a20e...72e2ed9. Read the comment docs.

@lucklove
Copy link
Member

lucklove commented Feb 2, 2021

Could you please modify local_install.sh too? It's used for offline installation

@terasum
Copy link
Contributor Author

terasum commented Feb 2, 2021

@lucklove sure! I will fix local_install.sh too!

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2021
@terasum
Copy link
Contributor Author

terasum commented Feb 2, 2021

@lucklove Hi, please take a look again, thanks.

@lucklove
Copy link
Member

lucklove commented Feb 2, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2021
@lucklove
Copy link
Member

lucklove commented Feb 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c22495a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2021
@ti-chi-bot
Copy link
Member

@terasum: Your PR has out-of-dated, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3299053 into pingcap:master Feb 2, 2021
@baurine
Copy link
Contributor

baurine commented Feb 2, 2021

Will we support it and when? it seems some guys start to use M1.

@lucklove
Copy link
Member

lucklove commented Feb 2, 2021

@baurine We need wait TiDB/TiKV/PD support that first, otherwise the user only have a bare TiUP

@baurine
Copy link
Contributor

baurine commented Feb 2, 2021

@baurine We need wait TiDB/TiKV/PD support that first, otherwise the user only have a bare TiUP

make sense, now the TiKV can't run on M1.

@AstroProfundis AstroProfundis added this to the v1.3.3 milestone Mar 1, 2021
@lucklove lucklove mentioned this pull request Mar 2, 2021
lucklove pushed a commit to lucklove/tiup that referenced this pull request Mar 4, 2021
* Add darwin-arm64 not support hint for install.sh 

The darwin-arm64 is not supported currently, and add some friendly hint.

* Update local_install.sh for darwin-arm64 hint

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants