-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support template command #1156
Support template command #1156
Conversation
To provide standard templates and detailed instructions in the template files Close pingcap#1024
Codecov Report
@@ Coverage Diff @@
## master #1156 +/- ##
===========================================
- Coverage 53.53% 42.49% -11.04%
===========================================
Files 284 223 -61
Lines 20302 16057 -4245
===========================================
- Hits 10868 6823 -4045
- Misses 7756 8062 +306
+ Partials 1678 1172 -506
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 82cc921
|
To provide standard templates and detailed instructions in the template files
Close #1024
What problem does this PR solve?
When a new user wants to use TiUP to deploy a cluster, he may don't know how to write the topology file, so he must open the browser and find the example topology. This is no a good experience.
What is changed and how it works?
I add a
template
command for bothtiup-cluster
andtiup-dm
, the command will print the topology templates:Check List
Tests
Code changes
Side effects
Related changes
Release notes: