-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: optimize checksum mismatch error #1170
*: optimize checksum mismatch error #1170
Conversation
7c2b762
to
39dbd11
Compare
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 39dbd11
|
@AstroProfundis: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
===========================================
- Coverage 53.59% 39.04% -14.55%
===========================================
Files 288 224 -64
Lines 20426 16099 -4327
===========================================
- Hits 10947 6286 -4661
- Misses 7798 8734 +936
+ Partials 1681 1079 -602
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
Add info to show the target that fails a checksum validation in error message, this could make it easier for users to know what went wrong.
Also cleanup some unused code after #906
Release notes: