Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: optimize checksum mismatch error #1170

Merged
merged 4 commits into from
Mar 2, 2021

Conversation

AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented Mar 2, 2021

What problem does this PR solve?

Add info to show the target that fails a checksum validation in error message, this could make it easier for users to know what went wrong.

Also cleanup some unused code after #906

Release notes:

NONE

@AstroProfundis AstroProfundis added type/enhancement Categorizes issue or PR as related to an enhancement. category/usability Categorizes issue or PR as a usability enhancement. labels Mar 2, 2021
@AstroProfundis AstroProfundis added this to the v1.4.0 milestone Mar 2, 2021
@AstroProfundis AstroProfundis requested a review from lucklove March 2, 2021 04:19
@AstroProfundis AstroProfundis self-assigned this Mar 2, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 2, 2021
@AstroProfundis AstroProfundis changed the title Optimize checksum error *: optimize checksum mismatch error Mar 2, 2021
@AstroProfundis AstroProfundis force-pushed the optimize-checksum-error branch from 7c2b762 to 39dbd11 Compare March 2, 2021 10:39
@lucklove
Copy link
Member

lucklove commented Mar 2, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2021
@lucklove
Copy link
Member

lucklove commented Mar 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 39dbd11

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-io
Copy link

codecov-io commented Mar 2, 2021

Codecov Report

Merging #1170 (0d5e5c3) into master (947e59f) will decrease coverage by 14.54%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1170       +/-   ##
===========================================
- Coverage   53.59%   39.04%   -14.55%     
===========================================
  Files         288      224       -64     
  Lines       20426    16099     -4327     
===========================================
- Hits        10947     6286     -4661     
- Misses       7798     8734      +936     
+ Partials     1681     1079      -602     
Flag Coverage Δ
cluster 39.04% <28.57%> (-6.06%) ⬇️
dm ?
integrate 39.04% <28.57%> (-8.96%) ⬇️
playground ?
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/download.go 36.84% <ø> (ø)
pkg/utils/sha.go 17.64% <0.00%> (-7.36%) ⬇️
pkg/cluster/clusterutil/cluster.go 57.57% <33.33%> (-3.72%) ⬇️
pkg/repository/v1_repository.go 39.54% <33.33%> (-24.10%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/queue/any_queue.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/telemetry/meta.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/telemetry/scrub.go 6.66% <0.00%> (-80.00%) ⬇️
... and 169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947e59f...0d5e5c3. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit aed6a75 into pingcap:master Mar 2, 2021
@AstroProfundis AstroProfundis deleted the optimize-checksum-error branch March 2, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants