Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: fix lightning's name not changed when cluster renamed #1196

Merged
merged 5 commits into from
Mar 12, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Mar 8, 2021

What problem does this PR solve?

fix #1166

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@9547 9547 changed the title grafana: fix lighting's name not changed when cluster renamed grafana: fix lightning's name not changed when cluster renamed Mar 8, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2021
@codecov-io
Copy link

codecov-io commented Mar 8, 2021

Codecov Report

Merging #1196 (acca1da) into master (1a8d77a) will increase coverage by 1.95%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
+ Coverage   31.50%   33.46%   +1.95%     
==========================================
  Files         295      254      -41     
  Lines       35249    17659   -17590     
==========================================
- Hits        11106     5909    -5197     
+ Misses      22421    10691   -11730     
+ Partials     1722     1059     -663     
Flag Coverage Δ
cluster 27.25% <0.00%> (-17.68%) ⬇️
dm 25.52% <33.33%> (+11.66%) ⬆️
integrate 33.46% <33.33%> (+5.25%) ⬆️
playground ?
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/api/binlog.go 0.00% <0.00%> (-39.48%) ⬇️
pkg/cluster/manager/display.go 63.38% <0.00%> (-19.13%) ⬇️
pkg/cluster/spec/validate.go 56.18% <ø> (-37.33%) ⬇️
pkg/cluster/spec/grafana.go 68.46% <100.00%> (-0.29%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
... and 177 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a8d77a...acca1da. Read the comment docs.

@AstroProfundis AstroProfundis added the category/monitoring Categorizes issue or PR related to monitoring components. label Mar 9, 2021
@9547 9547 force-pushed the fix/rename-grafana-lighting branch from bbf40d8 to 51b75b7 Compare March 10, 2021 14:35
@9547
Copy link
Contributor Author

9547 commented Mar 11, 2021

@lucklove PTAL

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: acca1da

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@ti-chi-bot ti-chi-bot merged commit 1fcd02b into pingcap:master Mar 12, 2021
@9547 9547 deleted the fix/rename-grafana-lighting branch March 18, 2021 16:05
@AstroProfundis AstroProfundis added the type/bug-fix Categorizes PR as a bug-fix label Mar 24, 2021
@AstroProfundis AstroProfundis added this to the v1.3.7 milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/monitoring Categorizes issue or PR related to monitoring components. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exec tiup cluster rename ; Grafana dashboard lightning new and old documents
5 participants