-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: support --nodes #1251
docker: support --nodes #1251
Conversation
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b13a3ec
|
Codecov Report
@@ Coverage Diff @@
## master #1251 +/- ##
===========================================
- Coverage 53.55% 33.77% -19.79%
===========================================
Files 289 254 -35
Lines 20773 17872 -2901
===========================================
- Hits 11126 6037 -5089
- Misses 7911 10785 +2874
+ Partials 1736 1050 -686
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@9547: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
I'm try to reproduce this issue #1187, and want to start N nodes, but currently TiUP only starts 5 nodes, I want to start more nodes, so I added this argument.
What is changed and how it works?
This PR will install the jinja2 tool from https://github.com/kolypto/j2cli, and use this tool to generate
--nodes
tiup-cluster-node.Check List
Tests
Code changes
Side effects
Related changes
Release notes: