Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/confirm reload patch rename #1263

Merged
merged 10 commits into from
Apr 1, 2021

Conversation

9547
Copy link
Contributor

@9547 9547 commented Mar 31, 2021

What problem does this PR solve?

implement #1255

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested review from lonng and lucklove March 31, 2021 17:12
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 31, 2021
@codecov-io
Copy link

codecov-io commented Mar 31, 2021

Codecov Report

Merging #1263 (ede00dd) into master (c9b58c9) will increase coverage by 13.84%.
The diff coverage is 28.57%.

❗ Current head ede00dd differs from pull request most recent head 573e256. Consider uploading reports for the commit 573e256 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1263       +/-   ##
===========================================
+ Coverage   26.28%   40.13%   +13.84%     
===========================================
  Files         263      243       -20     
  Lines       18840    18087      -753     
===========================================
+ Hits         4953     7260     +2307     
+ Misses      13115     9559     -3556     
- Partials      772     1268      +496     
Flag Coverage Δ
cluster 43.11% <28.57%> (?)
integrate 40.13% <28.57%> (+23.59%) ⬆️
playground 3.11% <ø> (?)
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/basic.go 51.45% <0.00%> (+51.45%) ⬆️
pkg/cluster/manager/patch.go 45.79% <0.00%> (+45.79%) ⬆️
pkg/cluster/manager/rename.go 16.00% <16.66%> (+16.00%) ⬆️
pkg/cluster/manager/reload.go 75.40% <80.00%> (+75.40%) ⬆️
components/cluster/command/patch.go 72.72% <100.00%> (+18.18%) ⬆️
components/cluster/command/reload.go 76.00% <100.00%> (+36.00%) ⬆️
components/cluster/command/rename.go 66.66% <100.00%> (+41.66%) ⬆️
components/cluster/command/restart.go 69.23% <100.00%> (+30.76%) ⬆️
components/cluster/command/stop.go 69.23% <100.00%> (+30.76%) ⬆️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
... and 257 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e280d83...573e256. Read the comment docs.

@lucklove
Copy link
Member

lucklove commented Apr 1, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2021
@lucklove
Copy link
Member

lucklove commented Apr 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9d9a1be

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2021
@ti-chi-bot ti-chi-bot merged commit 7e1f73b into pingcap:master Apr 1, 2021
@lucklove lucklove added this to the v1.4.1 milestone Apr 1, 2021
@AstroProfundis AstroProfundis modified the milestones: v1.4.1, v1.5.0 Apr 6, 2021
@9547 9547 deleted the feature/confirm-reload-patch-rename branch April 6, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants