Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for nightly versions in checkConfig() #1281

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

If a cluster is deployed with the real version of nightly of that day, e.g.: v5.0.0-nightly-20210405 instead of nightly, and when there is a new nightly version overwrites that value (and as we don't keep old nightly versions, the v5.0.0-nightly-20210405 then no longer available in the repo), a reload operation will fail with unknown version error.

If the cluster was deployed with nightly as version, all seems working correctly.

What is changed and how it works?

Check if the cluster version is a nightly version, and use nightly as version to query binary paths in repo for the component.

This may, in theory, encounter issues when the deployed nightly version was so far behind the real latest nightly version, the the entry point path of component has changed since it was deployed and last upgraded.

Note that this should be considered as a workaround only, and we may need to refactor the checkConfig() for better nightly version handling.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: workaround for config checks of manually deployed nightly versions

@AstroProfundis AstroProfundis added the type/bug-fix Categorizes PR as a bug-fix label Apr 6, 2021
@AstroProfundis AstroProfundis added this to the v1.4.1 milestone Apr 6, 2021
@AstroProfundis AstroProfundis requested a review from lucklove April 6, 2021 07:26
@AstroProfundis AstroProfundis self-assigned this Apr 6, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 6, 2021
@lucklove
Copy link
Member

lucklove commented Apr 6, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2021
@lucklove
Copy link
Member

lucklove commented Apr 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a7492ef

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@lucklove lucklove merged commit 39935d8 into pingcap:master Apr 7, 2021
@AstroProfundis AstroProfundis deleted the check-config-nightly branch April 7, 2021 11:01
AstroProfundis added a commit that referenced this pull request Apr 7, 2021
Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants