Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Updated doc/dev/README.md with relative links #1296

Merged
merged 4 commits into from
Apr 13, 2021
Merged

doc: Updated doc/dev/README.md with relative links #1296

merged 4 commits into from
Apr 13, 2021

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Apr 8, 2021

For easier navigation in github.

What problem does this PR solve?

Fix the links in the doc/dev/README.md file, to use relative links that work on github.

What is changed and how it works?

Only adding '../../' for links and correcting some.

Tests

  • Manual test (add detailed scripts or steps below)
    Checked the links on github
  • No code

Side effects
None (no code change)

Release notes:

NONE

@mjonss
Updated doc/dev/README.md with relative links
b746e32 
For easier navigation in github.
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested review from lonng and lucklove April 8, 2021 14:59
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 8, 2021
AstroProfundis
AstroProfundis reviewed Apr 9, 2021
View reviewed changes
doc/dev/README.md Outdated
@@ -61,4 +61,4 @@ Some key concepts:

### Manifest formats

See `ComponentManifest` and `VersionManifest` data structures in [component.go](pkg/repository/component.go) and [version.go](pkg/repository/version.go).
See `ComponentManifest` and `VersionManifest` data structures in [component.go](../../server/handler/component.go) and [version.go](../../pkg/version/version.go).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems out-dated, the manifest structures are defined in pkg/repository/types.go.

@AstroProfundis AstroProfundis added category/document Categorizes issue or PR as a document update. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Apr 9, 2021
lucklove
lucklove reviewed Apr 12, 2021
View reviewed changes
doc/dev/README.md Outdated Show resolved Hide resolved
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3437b0e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021
@ti-chi-bot ti-chi-bot merged commit 23876c0 into pingcap:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove lucklove left review comments

@AstroProfundis AstroProfundis AstroProfundis left review comments

@lonng lonng Awaiting requested review from lonng

Assignees
No one assigned
Labels
category/document Categorizes issue or PR as a document update. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mjonss @CLAassistant @lucklove @ti-chi-bot @AstroProfundis