Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: update mirror command #1302

Merged
merged 4 commits into from
Apr 13, 2021
Merged

tiup: update mirror command #1302

merged 4 commits into from
Apr 13, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

fix bugs and improve usability of `tiup mirror` sub command.

@AstroProfundis AstroProfundis added type/enhancement Categorizes issue or PR as related to an enhancement. type/bug-fix Categorizes PR as a bug-fix category/usability Categorizes issue or PR as a usability enhancement. labels Apr 13, 2021
@AstroProfundis AstroProfundis added this to the v1.4.2 milestone Apr 13, 2021
@AstroProfundis AstroProfundis requested a review from lucklove April 13, 2021 04:57
@AstroProfundis AstroProfundis self-assigned this Apr 13, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 13, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3d2139d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021
@ti-chi-bot ti-chi-bot merged commit ad2bc6a into pingcap:master Apr 13, 2021
@AstroProfundis AstroProfundis deleted the update-mirror-cmd branch April 13, 2021 06:54
@AstroProfundis AstroProfundis mentioned this pull request Apr 14, 2021
Open
AstroProfundis added a commit that referenced this pull request Apr 25, 2021
@AstroProfundis
tiup: update mirror command (#1302)
96f6e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove Awaiting requested review from lucklove

Assignees

@AstroProfundis AstroProfundis

Labels
category/usability Categorizes issue or PR as a usability enhancement. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.

tiup mirror init usage output incorrect tiup mirror init does not work
3 participants
@AstroProfundis @lucklove @ti-chi-bot