-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mirror clone: Improve handling of latest versions #1313
Conversation
1. If a version is specified and we fall back on the latest version then print a message about this. 2. Allow specifying "latest" as version to download the latest version of all components.
b347b15
to
2c09edd
Compare
I think it should be "latest" available version by default, so I'm not sure if it's necessary to add an alias to specify "latest". PTAL @lucklove |
Making "latest" the default would be ok with me as that is probably what people want if they don't specify
|
Oh I see, that's an issue of how |
Clever implementation!!! |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2c09edd
|
@dveeden: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@dveeden: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
What problem does this PR solve?
When running
tiup mirror clone ... v5.0.0
it may download a different version of a component if thereis no v5.0.0 for that component.
If you specify "v9999" it will cause
tiup mirror clone
to download the latest version of all components.What is changed and how it works?
Check List
Tests
Try
tiup mirror clone /path/to/tiup-mirror --os linux --arch amd64 latest
andtiup mirror clone /path/to/tiup-mirror --os linux --arch amd4 v5.0.0
.Related changes
Release notes: