Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository: set user agent for mirror requests #1342

Merged
merged 2 commits into from
May 6, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Set user-agent for HTTP requests make by repository, the default is grab now.

Related changes

  • Need to cherry-pick to the release branch

Release notes:

repository: set user agent for mirror requests

@AstroProfundis AstroProfundis added this to the v1.4.3 milestone Apr 30, 2021
@AstroProfundis AstroProfundis requested a review from lucklove April 30, 2021 10:10
@AstroProfundis AstroProfundis self-assigned this Apr 30, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #1342 (620c882) into master (54ac4d5) will increase coverage by 28.85%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1342       +/-   ##
===========================================
+ Coverage   25.88%   54.73%   +28.85%     
===========================================
  Files         264      290       +26     
  Lines       19713    21581     +1868     
===========================================
+ Hits         5103    11813     +6710     
+ Misses      13827     7918     -5909     
- Partials      783     1850     +1067     
Flag Coverage Δ
cluster 43.33% <100.00%> (?)
dm 18.92% <100.00%> (?)
integrate 49.02% <100.00%> (+33.22%) ⬆️
playground 14.47% <100.00%> (?)
tiup 15.80% <100.00%> (+<0.01%) ⬆️
unittest 22.42% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/mirror.go 40.07% <100.00%> (+0.63%) ⬆️
pkg/cluster/operation/destroy.go 56.61% <0.00%> (ø)
components/playground/instance/tikv.go 67.34% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/instance.go 45.45% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
pkg/cluster/operation/scale_in.go 58.27% <0.00%> (ø)
components/playground/instance/tiflash.go 59.09% <0.00%> (ø)
components/playground/instance/tidb.go 81.25% <0.00%> (ø)
pkg/cluster/operation/action.go 64.55% <0.00%> (ø)
... and 199 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ac4d5...620c882. Read the comment docs.

@lucklove
Copy link
Member

lucklove commented May 6, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2021
@lucklove
Copy link
Member

lucklove commented May 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 58860d9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2021
@ti-chi-bot ti-chi-bot merged commit c7536d9 into pingcap:master May 6, 2021
@AstroProfundis AstroProfundis deleted the update-ua branch May 11, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants