Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: make port check error message more clear to users. #1367

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

  • make error message for port range more clear to users, can help them to solve problems more quickly.

What is changed and how it works?

  • modify port range error message

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Release notes:

NONE

@CLAassistant
Copy link

CLAassistant commented May 17, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested review from breezewish and lucklove May 17, 2021 08:37
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2021

Codecov Report

Merging #1367 (bfee1d5) into master (f7ca6e5) will increase coverage by 29.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1367       +/-   ##
===========================================
+ Coverage   25.38%   54.43%   +29.05%     
===========================================
  Files         265      290       +25     
  Lines       20464    22347     +1883     
===========================================
+ Hits         5194    12165     +6971     
+ Misses      14473     8276     -6197     
- Partials      797     1906     +1109     
Flag Coverage Δ
cluster 41.81% <0.00%> (?)
dm 24.75% <0.00%> (?)
integrate 48.98% <0.00%> (+33.45%) ⬆️
playground 13.78% <0.00%> (?)
tiup 15.52% <0.00%> (ø)
unittest 21.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/validate.go 93.06% <100.00%> (+2.37%) ⬆️
pkg/cluster/operation/action.go 64.55% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 57.27% <0.00%> (ø)
pkg/cluster/operation/scale_in.go 58.27% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
pkg/logger/audit.go 53.33% <0.00%> (ø)
components/playground/instance/tidb.go 81.25% <0.00%> (ø)
components/playground/instance/tikv.go 67.34% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
pkg/cluster/operation/destroy.go 56.61% <0.00%> (ø)
... and 210 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ca6e5...bfee1d5. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2021
@AstroProfundis AstroProfundis added category/usability Categorizes issue or PR as a usability enhancement. component/cluster Issues about the tiup-cluster component good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels May 17, 2021
@AstroProfundis AstroProfundis added this to the v1.4.4 milestone May 17, 2021
@AstroProfundis AstroProfundis merged commit 3202e61 into pingcap:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. component/cluster Issues about the tiup-cluster component good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants