Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that it may panic when user try to list expired component #1391

Merged
merged 3 commits into from
May 28, 2021
Merged

Fix the issue that it may panic when user try to list expired component #1391

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4758905
Fix the issue that it may panic when user try to list expired component
lucklove May 28, 2021
4417be5
Update pkg/repository/v1_repository.go
AstroProfundis May 28, 2021
e1edd1e
Merge branch 'master' into fix-expired-component
ti-chi-bot May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/repository/v1_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,11 @@ func (r *V1Repository) updateComponentManifest(id string, withYanked bool) (*v1m

if oldVersion != 0 && oldVersion == fileVersion.Version {
// We're up to date, load the old manifest from disk.
return r.local.LoadComponentManifest(&item, filename)
comp, err := r.local.LoadComponentManifest(&item, filename)
if comp == nil && err == nil {
err = fmt.Errorf("component %s not exist", id)
AstroProfundis marked this conversation as resolved.
Show resolved Hide resolved
}
return comp, err
}

var component v1manifest.Component
Expand Down