-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue that exec command doesn't handle tiflash nodes #1431
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1431 +/- ##
===========================================
+ Coverage 25.23% 42.63% +17.39%
===========================================
Files 264 288 +24
Lines 20741 22592 +1851
===========================================
+ Hits 5235 9631 +4396
+ Misses 14703 11400 -3303
- Partials 803 1561 +758
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 145a6d4
|
What problem does this PR solve?
When execute the command
tiup cluster exec <cluster-name> -R tiflash
, tiup will do nothing because it can't deal with tiflash node correctlly.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: