Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that exec command doesn't handle tiflash nodes #1431

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Jun 17, 2021

What problem does this PR solve?

When execute the command tiup cluster exec <cluster-name> -R tiflash, tiup will do nothing because it can't deal with tiflash node correctlly.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@lucklove lucklove added this to the v1.5.2 milestone Jun 17, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #1431 (70ae852) into master (61b98df) will increase coverage by 17.39%.
The diff coverage is 0.00%.

❗ Current head 70ae852 differs from pull request most recent head 145a6d4. Consider uploading reports for the commit 145a6d4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1431       +/-   ##
===========================================
+ Coverage   25.23%   42.63%   +17.39%     
===========================================
  Files         264      288       +24     
  Lines       20741    22592     +1851     
===========================================
+ Hits         5235     9631     +4396     
+ Misses      14703    11400     -3303     
- Partials      803     1561      +758     
Flag Coverage Δ
cluster 29.17% <0.00%> (?)
integrate 36.57% <0.00%> (+21.15%) ⬆️
playground 13.70% <ø> (?)
tiup 15.42% <ø> (ø)
unittest 21.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/transfer.go 17.72% <0.00%> (+7.33%) ⬆️
pkg/logger/audit.go 53.33% <0.00%> (ø)
pkg/cluster/operation/systemd.go 0.00% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
pkg/cluster/operation/action.go 48.52% <0.00%> (ø)
pkg/cluster/operation/operation.go 34.78% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
pkg/cluster/operation/check.go 0.00% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
... and 146 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b98df...145a6d4. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2021
@AstroProfundis AstroProfundis added the component/cluster Issues about the tiup-cluster component label Jun 17, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 145a6d4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2021
@ti-chi-bot ti-chi-bot merged commit 26996ef into pingcap:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cluster Issues about the tiup-cluster component size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants