-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: fix bug which can't specify db port #1511
Merged
ti-chi-bot
merged 3 commits into
pingcap:master
from
hecomlilong:hotfix-playground-custom-db-port
Aug 16, 2021
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package instance | ||
|
|
||
| import ( | ||
| "github.com/BurntSushi/toml" | ||
| "github.com/pingcap/tidb/config" | ||
| ) | ||
|
|
||
| // GetTiDBPort custom db port for playground using config file | ||
| func GetTiDBPort(configPath string) int { | ||
| // default port | ||
| port := 4000 | ||
| // read from config file if possible | ||
| config := &config.Config{} | ||
| _, err := toml.DecodeFile(configPath, config) | ||
| if err == nil && config.Port > 0 { | ||
| port = int(config.Port) | ||
| } | ||
| return port | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package instance | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "os" | ||
| "testing" | ||
|
|
||
| "github.com/BurntSushi/toml" | ||
| "github.com/pingcap/tidb/config" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestGetTiDBPort(t *testing.T) { | ||
| defaultPort := 4000 | ||
| assert.Equal(t, GetTiDBPort(""), defaultPort) | ||
|
|
||
| customPort := 30000 | ||
| inputs := config.Config{ | ||
| Port: uint(customPort), | ||
| } | ||
| var firstBuffer bytes.Buffer | ||
| e := toml.NewEncoder(&firstBuffer) | ||
| err := e.Encode(inputs) | ||
| assert.Nil(t, err) | ||
| // create temp config file | ||
| tmp, err := os.CreateTemp(os.TempDir(), "tmp-") | ||
| assert.Nil(t, err) | ||
| defer tmp.Close() | ||
| _, err = tmp.Write(firstBuffer.Bytes()) | ||
| assert.Nil(t, err) | ||
|
|
||
| assert.Equal(t, GetTiDBPort(tmp.Name()), customPort) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are avoiding dependency upon
tidband other components by intend, please use general interface objects (map[string]interface{}with type assertion) to decode the config.Or simply provide a command line argument in
playgroundto specify TiDB port and overwrite the default.