Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show port of tidb when scale-out on playground #1520

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Aug 16, 2021

What problem does this PR solve?

Don't know which port to access the new node when scale-out tidb of playground, close #1319

What is changed and how it works?

add output like To connect new added TiDB: mysql --host 127.0.0.1 --port 40405 -u root -p (no password) --comments

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 16, 2021
@nexustar nexustar changed the title Scale out show port show port of tidb when scale-out on playground Aug 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #1520 (2721922) into master (c66dc09) will decrease coverage by 10.21%.
The diff coverage is n/a.

❗ Current head 2721922 differs from pull request most recent head ed9ed4a. Consider uploading reports for the commit ed9ed4a to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1520       +/-   ##
===========================================
- Coverage   26.25%   16.04%   -10.22%     
===========================================
  Files         267      150      -117     
  Lines       24052    15033     -9019     
===========================================
- Hits         6316     2412     -3904     
+ Misses      16913    12099     -4814     
+ Partials      823      522      -301     
Flag Coverage Δ
integrate 16.04% <ø> (ø)
tiup 16.04% <ø> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
embed/embed.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/spec/validate.go 0.00% <0.00%> (-91.42%) ⬇️
pkg/utils/diff.go 0.00% <0.00%> (-83.15%) ⬇️
pkg/utils/semver.go 4.72% <0.00%> (-81.89%) ⬇️
pkg/cluster/spec/parse_topology.go 0.00% <0.00%> (-81.09%) ⬇️
pkg/cluster/executor/checkpoint.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-77.78%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-75.76%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-71.43%) ⬇️
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66dc09...ed9ed4a. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2021
@AstroProfundis AstroProfundis added this to the v1.6.0 milestone Aug 16, 2021
@AstroProfundis AstroProfundis added the component/playground Issues about the tiup-playground component label Aug 16, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ed9ed4a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2021
@ti-chi-bot ti-chi-bot merged commit a7ccf6c into pingcap:master Aug 16, 2021
@nexustar nexustar deleted the scale-out-show-port branch August 16, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/playground Issues about the tiup-playground component size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display how to access new node after tiup playground scale-out
4 participants