-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/cluster/spec: add supported configuration for grafana #1566
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1566 +/- ##
===========================================
+ Coverage 26.20% 39.61% +13.40%
===========================================
Files 266 228 -38
Lines 24038 21071 -2967
===========================================
+ Hits 6300 8347 +2047
+ Misses 16916 11465 -5451
- Partials 822 1259 +437
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/cc @AstroProfundis |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5ba2032
|
What problem does this PR solve?
Add
default_theme
,org_name
,org_role
as supported configurations for Grafana.What is changed and how it works?
Add sub-targets under grafana_servers in topology.yaml which is used as the configuration file for
tiup-cluster deploy
command.Sample topology.yaml:
Check List
Tests
In Linux environment, run
make
under the project's root path to generate the binary file in the bin directoryRun
./tiup-cluster deploy test-tidb v5.1.1 /path/to/topology.yaml
and./tiup-cluster start test-tidb
to start a TiDB cluster. You can use the provided sample topology.yaml above, remember to substitute $HOST_IP with yours.Also, you may also need to provide credentials by passing
-u -p
or-u -i
in the deploy command, seetiup-cluster deploy -h
.Open browser and type in
$HOST_IP:3000
. If you use the provided topology.yaml file above, you should find that you have logged in automatically and the theme is light.You can also make sure that the configuration takes effect by checking the value of default_theme, org_name, org_role, enabled in /root/tidb-deploy/grafana-3000/conf/grafana.ini. It should be the same as below.
Code changes
Side effects
Related changes
Release notes: