Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests for go submodules #1579

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Component bench and client are not properly checked in CI.

What is changed and how it works?

Modify the Makefile to correctly pass the targets, and also fix error handling of bench.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Release notes:

NONE

@AstroProfundis AstroProfundis added this to the v1.6.1 milestone Oct 12, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nexustar

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@AstroProfundis AstroProfundis self-assigned this Oct 12, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 12, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #1579 (6b32357) into master (4b6f351) will increase coverage by 17.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1579       +/-   ##
===========================================
+ Coverage   26.04%   43.28%   +17.24%     
===========================================
  Files         266      228       -38     
  Lines       24195    21213     -2982     
===========================================
+ Hits         6301     9182     +2881     
+ Misses      17071    10668     -6403     
- Partials      823     1363      +540     
Flag Coverage Δ
cluster 43.28% <ø> (?)
integrate 43.28% <ø> (+27.50%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/model/publish.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-82.61%) ⬇️
pkg/utils/semver.go 7.08% <0.00%> (-79.53%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-77.78%) ⬇️
pkg/repository/progress.go 23.07% <0.00%> (-76.93%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-75.76%) ⬇️
... and 249 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6f351...6b32357. Read the comment docs.

@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 79bc965

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a11bd32 into pingcap:master Oct 13, 2021
@AstroProfundis AstroProfundis deleted the fix-submod branch October 20, 2021 03:53
AstroProfundis added a commit that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants