-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tests for go submodules #1579
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1579 +/- ##
===========================================
+ Coverage 26.04% 43.28% +17.24%
===========================================
Files 266 228 -38
Lines 24195 21213 -2982
===========================================
+ Hits 6301 9182 +2881
+ Misses 17071 10668 -6403
- Partials 823 1363 +540
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 79bc965
|
@AstroProfundis: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Component
bench
andclient
are not properly checked in CI.What is changed and how it works?
Modify the
Makefile
to correctly pass the targets, and also fix error handling ofbench
.Check List
Tests
Code changes
Release notes: