-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: add envs to skip topology sanity check in scale-in process #1627
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1627 +/- ##
===========================================
+ Coverage 15.59% 40.70% +25.10%
===========================================
Files 151 260 +109
Lines 15234 23349 +8115
===========================================
+ Hits 2376 9504 +7128
- Misses 12341 12457 +116
- Partials 517 1388 +871
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 533a951
|
What problem does this PR solve?
Close #1616
What is changed and how it works?
Add 2 new environment variables in
pkg/cluster/operation
:SKIP_SCALEIN_TOPO_CHECK
: If not empty, skip topology sanity check so that it's possible to delete the last PD, the last TiKV and the last TiSpark master node with worker node remainsFORCE_PD_ENDPOINTS
: A common separated list of available PD endpoints. Used to overwrite pd list in the topology, so that when there is no PD available in the topologytiup-cluster
acknowledged but some are working in the actual cluster, it's still possible to scale in other instancesThese two environment are very dangerous and are highly possible to make the cluster broken, so they are not supposed to be documented in any public documentations, they are only supposed to be used by developers and expert users who know 100% what they are doing.
Check List
Tests
Code changes
Release notes: