Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: clean operations cannot cleanup monitor component files #1643

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented Nov 29, 2021

What problem does this PR solve?

clean operations cannot cleanup monitor data/log/tls files

for example:
image

What is changed and how it works?

image

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Check whether the output file contains the monitor component

 ./tiup-cluster clean <cluster-name> --ignore-node <host> --ignore-role <role> --data
 ./tiup-cluster clean <cluster-name> --ignore-node <host> --ignore-role <role> --log
 ./tiup-cluster clean <cluster-name> --ignore-node <host> --ignore-role <role> --all

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@srstack srstack self-assigned this Nov 29, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #1643 (140e559) into master (2dba6d7) will increase coverage by 32.37%.
The diff coverage is 76.19%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1643       +/-   ##
===========================================
+ Coverage   15.55%   47.92%   +32.37%     
===========================================
  Files         151      294      +143     
  Lines       15275    26973    +11698     
===========================================
+ Hits         2376    12927    +10551     
+ Misses      12382    12037      -345     
- Partials      517     2009     +1492     
Flag Coverage Δ
cluster 39.27% <76.19%> (?)
dm 26.01% <0.00%> (?)
integrate 47.92% <76.19%> (+32.37%) ⬆️
playground 13.31% <ø> (?)
tiup 15.55% <ø> (ø)
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/cleanup.go 54.76% <75.00%> (ø)
pkg/cluster/manager/basic.go 51.47% <83.33%> (ø)
pkg/cluster/task/init_config.go 44.44% <0.00%> (ø)
pkg/logger/audit.go 57.89% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
pkg/cluster/ansible/inventory.go 0.00% <0.00%> (ø)
components/dm/command/stop.go 83.33% <0.00%> (ø)
pkg/cluster/manager/check.go 72.27% <0.00%> (ø)
pkg/cluster/manager/scale_out.go 29.07% <0.00%> (ø)
pkg/cluster/manager/rename.go 19.23% <0.00%> (ø)
... and 238 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dba6d7...140e559. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 140e559

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2021
@ti-chi-bot ti-chi-bot merged commit 0349e97 into pingcap:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants