Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix port conflict check for tiflash instances #1805

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

The Flash* ports are not checked for conflicts for tiflash instances.

Check List

Tests

  • Unit test

@AstroProfundis AstroProfundis added this to the v1.9.3 milestone Mar 22, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@AstroProfundis AstroProfundis self-assigned this Mar 22, 2022
@ti-chi-bot ti-chi-bot requested a review from srstack March 22, 2022 10:52
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #1805 (eeeac68) into master (62dc752) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1805      +/-   ##
==========================================
- Coverage   53.05%   53.03%   -0.02%     
==========================================
  Files         303      303              
  Lines       34641    34644       +3     
==========================================
- Hits        18378    18373       -5     
- Misses      14102    14113      +11     
+ Partials     2161     2158       -3     
Flag Coverage Δ
cluster 41.28% <100.00%> (-0.04%) ⬇️
dm 24.83% <0.00%> (-<0.01%) ⬇️
playground 12.63% <0.00%> (-<0.01%) ⬇️
tiup 14.42% <0.00%> (+0.02%) ⬆️
unittest 21.31% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/validate.go 92.97% <100.00%> (+0.03%) ⬆️
pkg/utils/retry.go 46.43% <0.00%> (-16.07%) ⬇️
pkg/cluster/spec/tikv.go 61.31% <0.00%> (-1.31%) ⬇️
pkg/cluster/api/pdapi.go 56.94% <0.00%> (-0.53%) ⬇️
pkg/cluster/spec/tiflash.go 69.18% <0.00%> (+0.67%) ⬆️
pkg/repository/store/txn.go 59.04% <0.00%> (+2.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62dc752...eeeac68. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
@srstack
Copy link
Collaborator

srstack commented Mar 23, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eeeac68

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2022
@ti-chi-bot ti-chi-bot merged commit 3e08e7a into pingcap:master Mar 23, 2022
@AstroProfundis AstroProfundis deleted the tiflash-ports branch March 23, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants