-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: fix port conflict check for tiflash instances #1805
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #1805 +/- ##
==========================================
- Coverage 53.05% 53.03% -0.02%
==========================================
Files 303 303
Lines 34641 34644 +3
==========================================
- Hits 18378 18373 -5
- Misses 14102 14113 +11
+ Partials 2161 2158 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: eeeac68
|
What problem does this PR solve?
The Flash* ports are not checked for conflicts for tiflash instances.
Check List
Tests