Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: display grafana URL on the top #1819

Merged
merged 13 commits into from
Mar 31, 2022
Merged

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented Mar 26, 2022

I want to show grafana URL in the top, to remind users they can access Grafana directly like Dashborad
QQ20220325-210234@2x

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2022

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2022

Codecov Report

Merging #1819 (fe932fc) into master (514d2ae) will decrease coverage by 8.71%.
The diff coverage is 100.00%.

❗ Current head fe932fc differs from pull request most recent head 3aced53. Consider uploading reports for the commit 3aced53 to get more accurate results

@@            Coverage Diff             @@
##           master    #1819      +/-   ##
==========================================
- Coverage   52.90%   44.20%   -8.71%     
==========================================
  Files         303      303              
  Lines       34663    34678      +15     
==========================================
- Hits        18338    15326    -3012     
- Misses      14172    17528    +3356     
+ Partials     2153     1824     -329     
Flag Coverage Δ
cluster 29.49% <100.00%> (-11.64%) ⬇️
dm 18.88% <0.00%> (-5.85%) ⬇️
playground 12.63% <ø> (ø)
unittest 21.31% <66.67%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/display.go 37.81% <100.00%> (-9.88%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/task/update_dm_meta.go 0.00% <0.00%> (-87.76%) ⬇️
pkg/cluster/template/scripts/tiflash.go 0.00% <0.00%> (-77.94%) ⬇️
pkg/cluster/operation/systemd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/cluster/template/systemd/tispark.go 0.00% <0.00%> (-65.71%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-65.22%) ⬇️
pkg/cluster/template/scripts/tispark.go 0.00% <0.00%> (-63.79%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-63.64%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514d2ae...3aced53. Read the comment docs.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2022
@Smityz Smityz changed the title cluster: display grafana URL in the top cluster: display grafana URL on the top Mar 26, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2022
@AstroProfundis AstroProfundis added this to the v1.10.0 milestone Mar 31, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3aced53

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2022
@ti-chi-bot ti-chi-bot merged commit 9060112 into pingcap:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants