Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup: refactor help #1831

Merged
merged 3 commits into from
Apr 18, 2022
Merged

tiup: refactor help #1831

merged 3 commits into from
Apr 18, 2022

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Apr 2, 2022

What problem does this PR solve?

What is changed and how it works?

  • refactor tiup help. remove hack, just use cobra help or simply passthrough -h/--help to component
  • not parse flags on root command, add a switch instead

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from july2993 and lonng April 2, 2022 06:36
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 2, 2022
@nexustar nexustar added this to the v1.10.0 milestone Apr 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

Merging #1831 (7336297) into master (6e8d6e2) will decrease coverage by 7.66%.
The diff coverage is 58.93%.

@@            Coverage Diff             @@
##           master    #1831      +/-   ##
==========================================
- Coverage   52.71%   45.06%   -7.66%     
==========================================
  Files         307      306       -1     
  Lines       35076    34975     -101     
==========================================
- Hits        18490    15759    -2731     
- Misses      14419    17336    +2917     
+ Partials     2167     1880     -287     
Flag Coverage Δ
cluster 28.63% <ø> (-12.47%) ⬇️
dm 24.55% <ø> (-0.16%) ⬇️
playground 12.52% <ø> (-0.09%) ⬇️
tiup 14.15% <58.93%> (-0.43%) ⬇️
unittest 21.26% <26.79%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/root.go 56.36% <58.93%> (-4.85%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/tiflash.go 0.00% <0.00%> (-77.94%) ⬇️
pkg/cluster/operation/systemd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/cluster/template/systemd/tispark.go 0.00% <0.00%> (-65.71%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-65.22%) ⬇️
pkg/cluster/template/scripts/tispark.go 0.00% <0.00%> (-63.79%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-63.64%) ⬇️
pkg/cluster/manager/check.go 5.20% <0.00%> (-63.59%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8d6e2...7336297. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7336297

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2022
@ti-chi-bot ti-chi-bot merged commit e475745 into pingcap:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error when tag name is the same as component name
5 participants