Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: display support concurrent access to node status #1867

Conversation

srstack
Copy link
Collaborator

@srstack srstack commented May 3, 2022

What problem does this PR solve?

display support concurrent access to node status

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@srstack srstack requested review from AstroProfundis and nexustar May 3, 2022 10:13
@srstack srstack self-assigned this May 3, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 3, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #1867 (e0b0aba) into master (378989e) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
- Coverage   52.60%   52.57%   -0.04%     
==========================================
  Files         306      306              
  Lines       35036    35065      +29     
==========================================
+ Hits        18430    18432       +2     
- Misses      14441    14464      +23     
- Partials     2165     2169       +4     
Flag Coverage Δ
cluster 40.88% <100.00%> (-0.04%) ⬇️
dm 24.60% <45.95%> (+0.02%) ⬆️
playground 12.77% <0.00%> (-0.01%) ⬇️
tiup 14.40% <0.00%> (-0.06%) ⬇️
unittest 21.24% <38.89%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/spec/logic.go 67.75% <100.00%> (+1.54%) ⬆️
pkg/cluster/manager/display.go 49.19% <100.00%> (+0.09%) ⬆️
pkg/cluster/operation/check.go 48.51% <100.00%> (ø)
pkg/cluster/spec/spec.go 83.79% <100.00%> (+0.46%) ⬆️
pkg/cluster/spec/pump.go 61.84% <0.00%> (-4.61%) ⬇️
pkg/utils/http_client.go 46.56% <0.00%> (-2.29%) ⬇️
pkg/repository/store/txn.go 56.91% <0.00%> (-2.13%) ⬇️
pkg/cluster/api/pdapi.go 59.05% <0.00%> (-1.58%) ⬇️
pkg/cluster/operation/destroy.go 59.45% <0.00%> (-0.64%) ⬇️
pkg/cluster/api/binlog.go 36.08% <0.00%> (-0.63%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378989e...e0b0aba. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2022
@AstroProfundis AstroProfundis changed the title cluster :display support concurrent access to node status cluster: display support concurrent access to node status May 9, 2022
@AstroProfundis AstroProfundis added this to the 1.9.5 milestone May 9, 2022
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e0b0aba

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2022
@ti-chi-bot ti-chi-bot merged commit 3b24388 into pingcap:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants