Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: detect error log #1882

Merged
merged 2 commits into from
May 17, 2022
Merged

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • srstack

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #1882 (d63a63a) into master (f062b88) will decrease coverage by 14.43%.
The diff coverage is n/a.

❗ Current head d63a63a differs from pull request most recent head 631f2fb. Consider uploading reports for the commit 631f2fb to get more accurate results

@@             Coverage Diff             @@
##           master    #1882       +/-   ##
===========================================
- Coverage   52.85%   38.42%   -14.43%     
===========================================
  Files         307      306        -1     
  Lines       35153    35142       -11     
===========================================
- Hits        18577    13501     -5076     
- Misses      14389    19791     +5402     
+ Partials     2187     1850      -337     
Flag Coverage Δ
cluster 30.47% <ø> (-10.77%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/task/update_dm_meta.go 0.00% <0.00%> (-87.76%) ⬇️
pkg/cluster/template/config/ngmonitoring.go 0.00% <0.00%> (-76.47%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-76.19%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/crypto/rand/passwd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/cluster/operation/systemd.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-70.73%) ⬇️
pkg/cluster/manager/check.go 0.67% <0.00%> (-68.12%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-65.22%) ⬇️
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f062b88...631f2fb. Read the comment docs.

@nexustar nexustar added this to the v1.10.0 milestone May 13, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 14, 2022
@nexustar
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 631f2fb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@ti-chi-bot ti-chi-bot merged commit bdac542 into pingcap:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants