-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: Fix "--tag" argument for subcommands. #1998
Conversation
Issue Number: pingcap#1997 Signed-off-by: pingyu <yuping@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: pingyu <yuping@pingcap.com>
Codecov Report
@@ Coverage Diff @@
## master #1998 +/- ##
==========================================
- Coverage 44.93% 42.68% -2.25%
==========================================
Files 308 272 -36
Lines 35887 31565 -4322
==========================================
- Hits 16123 13472 -2651
+ Misses 17828 16421 -1407
+ Partials 1936 1672 -264
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@nexustar: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b2c523f
|
Issue Number: #1997
Signed-off-by: pingyu yuping@pingcap.com
What problem does this PR solve?
Close #1997 .
What is changed and how it works?
Use
rootCmd.PersistentFlags()
to add the "--tag" argument, other thanrootCmd.Flags()
, which is invisible to subcommands. Refer to https://github.com/spf13/cobra/blob/main/user_guide.md#persistent-flags.Check List
Tests
Code changes
Side effects
Related changes
Release notes: