Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve install.sh and release ci #2301

Merged
merged 1 commit into from
Nov 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/release-tiup.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,6 @@ jobs:
echo ${{ secrets.TIUP_COMP_KEY_PINGCAP }} | base64 -d > $TIUP_HOME/keys/private.json
# build the latest tiup to use for publish, this is a workaround and should
# be removed after this PR is merged and released
GOOS=linux GOARCH=amd64 make tiup
cp bin/tiup ${TIUP_BIN}
# add a random delay before actually publishing, this can help reduce manifest conflict
# when there are multiple jobs running in parallel
sleep $[ ( $RANDOM % 10 ) ]s
Expand Down
2 changes: 1 addition & 1 deletion install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ fi
echo "Shell profile: ${bold}$PROFILE${sgr0}"

case :$PATH: in
*:$bin_dir:*) : "PATH already contains $bin_dir" ;;
*:$bin_dir:*) echo "PATH already contains $bin_dir" ;;
*) printf '\nexport PATH=%s:$PATH\n' "$bin_dir" >> "$PROFILE"
echo "$PROFILE has been modified to add tiup to PATH"
echo "open a new terminal or ${bold}source ${PROFILE}${sgr0} to use it"
Expand Down
Loading