cluster: Improve cluster restart messaging #2442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cluster restart messaging indicates to user that the:
tiup/pkg/cluster/manager/basic.go
Line 235 in 654b087
This message is confusing when the command run only requests a single node restart, especially monitoring nodes or ones in an HA deployment.
What is changed and how it works?
Commit changes the messaging so that users performing full cluster restart retain the same message as before. But users only restarting selected nodes or roles will have that replaced with a more detailed warning message:
Cluster functionality related to nodes: %s and roles: % will be unavailable
Check List
Tests
Code changes
Side effects
Related changes
Release notes: