Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: display dashboard server URLs #2472

Merged
merged 2 commits into from
Nov 12, 2024
Merged

cluster: display dashboard server URLs #2472

merged 2 commits into from
Nov 12, 2024

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Nov 8, 2024 •
edited
Loading

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Close #2470

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

aae6846c-a798-43d1-adb3-eb99b934c8cb

  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@xhebox
cluster: display dashboard server URLs
06dd2c0 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested review from nexustar and srstack November 8, 2024 03:12
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2024
xhebox
xhebox commented Nov 8, 2024
View reviewed changes
pkg/cluster/manager/display.go
if tlsCfg != nil {
fmt.Println(
"Client certificate:",
color.CyanString(m.specManager.Path(clusterName, spec.TLSCertKeyDir, spec.PFXClientCert)),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe PFX format is deprecated, right @kaaaaaaang ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about its deprecation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bring back the old code for now.

kaaaaaaang
kaaaaaaang reviewed Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@kaaaaaaang kaaaaaaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest /lgtm

@xhebox
revert legacy behavior back
efade3f 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaaaaaaang
Once this PR has been reviewed and has the lgtm label, please ask for approval from xhebox, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xhebox xhebox merged commit 505444d into pingcap:master Nov 12, 2024
15 of 20 checks passed
@xhebox xhebox deleted the dashboard branch November 12, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nexustar nexustar Awaiting requested review from nexustar

@srstack srstack Awaiting requested review from srstack

@kaaaaaaang kaaaaaaang Awaiting requested review from kaaaaaaang

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems that standalone Dashbaord displays in tiup
2 participants
@xhebox @kaaaaaaang