Support yank a single version on client side #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
==========================================
+ Coverage 50.73% 51.22% +0.49%
==========================================
Files 220 225 +5
Lines 16102 16573 +471
==========================================
+ Hits 8169 8490 +321
- Misses 6787 6899 +112
- Partials 1146 1184 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
The yanked version handle has been complete in #602 |
lonng
reviewed
Jul 15, 2020
cmd/mirror.go
Outdated
| @@ -253,15 +254,22 @@ func newMirrorModifyCmd() *cobra.Command { | |||
| return err | |||
| } | |||
|
|
|||
| m, err := env.V1Repository().FetchComponentManifest(args[0]) | |||
| spec := strings.Split(args[0], ":") | |||
There was a problem hiding this comment.
Please use ParseComponentVersion function.
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
lonng
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this time tiup only supports yank a whole component (include all versions).
In some scenes, we should yank a single version (for example, we push a wrong version).
This PR makes it possible to yank a single version.