-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support use local file or directory as config for monitor components #712
Conversation
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #712 +/- ##
==========================================
+ Coverage 57.97% 58.00% +0.02%
==========================================
Files 253 253
Lines 18530 18660 +130
==========================================
+ Hits 10743 10823 +80
- Misses 6365 6397 +32
- Partials 1422 1440 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can those *.json
can be generated dynamically?
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
No, they have too many things. |
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Co-authored-by: Lonng <heng@lonng.org>
Co-authored-by: Lonng <heng@lonng.org>
Co-authored-by: Lonng <heng@lonng.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
* Document for pingcap/tiup#712 Signed-off-by: lucklove <gnu.crazier@gmail.com> * More detail Signed-off-by: lucklove <gnu.crazier@gmail.com> * Apply suggestions from code review Co-authored-by: Lonng <heng@lonng.org> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update tiup/tiup-cluster.md Co-authored-by: Lonng <heng@lonng.org> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TODOLIST:
What problem does this PR solve?
What is changed and how it works?
Make it possible to specify additional file (or dir) path in topology or meta.yml. In deploy and reload stage, tiup will copy these things to remote.
Check List
Tests
Code changes
Related changes
Release notes: