Fix the issue that tiflash's data is not clean up when tombstone #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use ServicePort in DestroyClusterTombstone to construct id and filter by id, but the id of instances of cluster is contract using Port(TCPPort for tiflash), so it will not get the instance and clean it's data in DestroyClusterTombstone. Note the GetMainPort() is TCPPort now, change the code to both using GetMainPort() to avoid inconsistent.
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
+ Coverage 58.76% 58.78% +0.01%
==========================================
Files 257 258 +1
Lines 19463 19592 +129
==========================================
+ Hits 11438 11517 +79
- Misses 6507 6545 +38
- Partials 1518 1530 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lucklove
pushed a commit
that referenced
this pull request
Sep 11, 2020
We use ServicePort in DestroyClusterTombstone to construct id and filter by id, but the id of instances of cluster is contract using Port(TCPPort for tiflash), so it will not get the instance and clean it's data in DestroyClusterTombstone. Note the GetMainPort() is TCPPort now, change the code to both using GetMainPort() to avoid inconsistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the issue that tiflash's data is not clean up when tombstone
when tombstone
before this pr:
after this pr:
What is changed and how it works?
We use ServicePort in DestroyClusterTombstone to construct id and filter by id,
but the id of instances of the cluster is construct using Port(TCPPort for
tiflash),
so it will not get the instance and clean its data in DestroyClusterTombstone.
Note the GetMainPort() is TCPPort now, change the code to both
using GetMainPort() to avoid inconsistent.
Check List
Tests
deploy -> scale-in -> check work as expect
Release notes: