-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the dependencies field to match the specification #953
Conversation
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
==========================================
- Coverage 55.81% 52.00% -3.81%
==========================================
Files 263 263
Lines 19513 19513
==========================================
- Hits 10891 10148 -743
- Misses 6889 7724 +835
+ Partials 1733 1641 -92
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/merge |
@lucklove: you cannot merge your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository. |
/merge |
@9547: adding 'status/cam-merge' is restricted to committers in list. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository. |
/hold |
@9547 I found a bug ): |
We can't upgrade spec_version at this time, until #960 resolved. |
/hold cancel |
What problem does this PR solve?
As https://github.com/pingcap/tiup/blame/master/doc/design/manifest.md#L256 specified, the dependencies filed should be
map[string]string
. But in the current implementation, it's[]string
, fortunately, this field is not used up until now and it's aways anull
in the manifest json file, which adopted both[]string
andmap[string]string
. But in the future, we may use this field, so it's better to correct it as early as possible.What is changed and how it works?
[]string
tomap[string]string
v0.1.0
tov0.1.1
Check List
Tests
Code changes
Side effects
Related changes
Release notes: