Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager/deploy: do not allow deploying of empty topology #994

Merged
merged 3 commits into from
Dec 17, 2020
+17 −0
Merged

manager/deploy: do not allow deploying of empty topology #994

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
406fa54
manager/deploy: do not allow deploying of empty topology
AstroProfundis Dec 16, 2020
9019f26
Merge branch 'master' into empty-deploy
lucklove Dec 17, 2020
5bdd4f1
Merge branch 'master' into empty-deploy
ti-chi-bot Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions pkg/cluster/manager/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,23 @@ func (m *Manager) Deploy(
return err
}

instCnt := 0
topo.IterInstance(func(inst spec.Instance) {
switch inst.ComponentName() {
// monitoring components are only useful when deployed with
// core components, we do not support deploying any bare
// monitoring system.
case spec.ComponentGrafana,
spec.ComponentPrometheus,
spec.ComponentAlertmanager:
return
}
instCnt++
})
if instCnt < 1 {
return fmt.Errorf("no valid instance found in the input topology, please check your config")
}

spec.ExpandRelativeDir(topo)

base := topo.BaseTopo()
Expand Down