Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: gather all simple "backend adapter" example into one #365

Closed
juliusmarminge opened this issue Sep 17, 2023 · 1 comment · Fixed by #371
Closed

examples: gather all simple "backend adapter" example into one #365

juliusmarminge opened this issue Sep 17, 2023 · 1 comment · Fixed by #371

Comments

@juliusmarminge
Copy link
Member

juliusmarminge commented Sep 17, 2023

We should think on how we want to structure ezamples. Having the same vite app like 10 times hurts CI time a looot, especially from forks that cant use the remote cache.

I wonder if a single vite app "connecting" to localhost:3000 and then all the backend adapters can be like 2 files 🤔 food for thought.

Really it could even just be a single example with a single router, and then just a bunch of different `dev:hono`, `dev:fastify` scripts that starts a different server 🤔

Originally posted by @juliusmarminge in #364 (review)

@juliusmarminge
Copy link
Member Author

I'm thinking something like:

examples/
  backend-adapters/
    client/ # a vite react app that proxies /api to localhost:3000
    server/
      src/
        router.ts # a single upload router
        express.ts # an express server
        fastify.ts # a fastify server
        elysia.ts
        ...

then have scripts like dev:elysia which starts the vite app and the elysia server.

this should greatly reduce the concurrency limit for turbo which is slowing down CI significantly right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant