Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Doc page with Fetch runtime setup examples #364

Merged
merged 10 commits into from
Sep 17, 2023
Merged

chore: Doc page with Fetch runtime setup examples #364

merged 10 commits into from
Sep 17, 2023

Conversation

Mr0Bread
Copy link
Contributor

Created new doc page that explains process of setting up UT on server-side that are based on Request/Response

As an example I referred to: https://trpc.io/docs/server/adapters/fetch

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9ce5aac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2023 6:38pm

@Mr0Bread Mr0Bread mentioned this pull request Sep 17, 2023
Open
3 tasks
@Mr0Bread
Copy link
Contributor Author

Should doc page contain links to examples source code/stackblitz?

juliusmarminge
juliusmarminge approved these changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@juliusmarminge juliusmarminge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think on how we want to structure ezamples. Having the same vite app like 10 times hurts CI time a looot, especially from forks that cant use the remote cache.

I wonder if a single vite app "connecting" to localhost:3000 and then all the backend adapters can be like 2 files 🤔 food for thought.

Really it could even just be a single example with a single router, and then just a bunch of different dev:hono, dev:fastify scripts that starts a different server 🤔

docs/src/pages/backend-adapters/fetch.mdx Outdated Show resolved Hide resolved
docs/src/pages/backend-adapters/fetch.mdx Outdated Show resolved Hide resolved
@Mr0Bread
Copy link
Contributor Author

Really it could even just be a single example with a single router, and then just a bunch of different dev:hono, dev:fastify scripts that starts a different server 🤔

Probably then something like that

  • examples
    • minimal-backend-react
      • client
      • fastify
      • express
      • hono
      • elysia

@Mr0Bread
Copy link
Contributor Author

I can make such refactorings to examples of backend adapters in scope of this PR

@juliusmarminge
Copy link
Collaborator

I can make such refactorings to examples of backend adapters in scope of this PR

I'd say Leave it for a follow up

@juliusmarminge juliusmarminge mentioned this pull request Sep 17, 2023
Closed
@juliusmarminge juliusmarminge merged commit 32de99a into pingdotgg:main Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

Assignees
No one assigned
Labels
📚 documentation examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mr0Bread @juliusmarminge