chore(release): 📦 version packages #1115
Conversation
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
78861c4 to
71e23cf
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
WalkthroughThis pull request involves the removal of a changelog entry and version updates across multiple packages in the UploadThing ecosystem. The changes primarily focus on incrementing versions for packages like Changes
Possibly related PRs
Suggested labels
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
301c8ad to
e4c6d50
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
7cb39fe to
bc1cef3
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
98bd447 to
23f8eaf
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
9392825 to
7c45df6
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
e214200 to
28272b6
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/react/CHANGELOG.md (1)
258-259: Fix markdown formatting for URL.The bare URL should be wrapped in angle brackets for better markdown formatting.
- https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 + <https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61>🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/expo/CHANGELOG.md (1)
130-131: Add missing comma for better readabilityConsider adding a comma after "sometimes" to improve readability.
- fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function` + fix vite monorepos sometimes, complaining about `$RefreshSig$ is not a function`🧰 Tools
🪛 LanguageTool
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md (2)
3-10: Consider enhancing the changelog entry with more details.While the entry follows good practices by including PR/commit links and proper crediting, the description "feat: allow custom fetch override" could be more detailed to help users understand the feature's purpose and usage.
Consider expanding the description to include:
- Why this feature was added
- How users can utilize the custom fetch override
- Any breaking changes or migration notes
303-304: Use proper Markdown link syntax for URLs.Convert the bare URL to proper Markdown link syntax for better maintainability and accessibility.
- https://docs.uploadthing.com/getting-started/svelte + [Svelte Documentation](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (30)
- packages/vue/package.json
- examples/with-serveractions/package.json
- packages/nuxt/package.json
- examples/backend-adapters/server/package.json
- packages/uploadthing/package.json
- packages/svelte/package.json
- examples/minimal-pagedir/package.json
- examples/with-clerk-remix/package.json
- examples/with-clerk-pagesdir/package.json
- packages/solid/CHANGELOG.md
- packages/solid/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-expo/package.json
- examples/with-novel/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/backend-adapters/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-sveltekit/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-tanstack-start/package.json
- examples/with-react-image-crop/package.json
- examples/minimal-appdir/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-drizzle-appdir/package.json
- packages/expo/package.json
- examples/with-tailwindcss/package.json
- packages/react/package.json
- examples/minimal-nuxt/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~137-~137: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...
(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md
[uncategorized] ~168-~168: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
258-258: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
304-304: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
313-313: null
Bare URL used
(MD034, no-bare-urls)
487-487: null
Bare URL used
(MD034, no-bare-urls)
565-565: null
Bare URL used
(MD034, no-bare-urls)
712-712: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (12)
packages/react/CHANGELOG.md (2)
3-10: LGTM! Latest version changes are well documented.The changelog entry for version 7.2.0 properly documents:
- The minor change allowing custom fetch override
- Links to PR feat: add custom fetch override #1099 and commit hash
- Credits contributor @juliusmarminge
Line range hint
1-534: LGTM! The changelog follows best practices.The changelog:
- Follows the Keep a Changelog format
- Uses semantic versioning
- Properly documents breaking changes
- Tracks dependencies
- Credits contributors
🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM: Version bump and changelog entry are appropriate.The patch version bump to 7.1.6 correctly reflects the dependency update to @uploadthing/vue@7.2.0, following semantic versioning principles.
Line range hint
1-241: LGTM: Changelog format is consistent.The changelog maintains a consistent format across all versions, properly documenting:
- Version numbers
- Change types
- PR references
- Commit hashes
- Contributor credits
packages/expo/CHANGELOG.md (1)
3-16: LGTM! Well-structured changelog entry.The changelog entry for version 7.2.0 is properly formatted and accurately documents:
- The new custom fetch override feature
- Credit to contributor @juliusmarminge
- Updated dependency on @uploadthing/react
packages/svelte/CHANGELOG.md (1)
Line range hint
1-309: Well-structured changelog format!The changelog follows the Keep a Changelog format consistently, with proper categorization of changes and clear version history.
🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...(EN_EXCESSIVE_EXCLAMATION)
packages/uploadthing/CHANGELOG.md (1)
3-10: LGTM! The latest version entry is well-documented.The changelog entry for version 7.5.0 is properly formatted and includes:
- Clear description of the minor change (custom fetch override)
- PR reference (feat: add custom fetch override #1099)
- Commit hash reference
- Contributor attribution
examples/profile-picture/package.json (2)
22-22: LGTM! Version updates align with release objectives.The updates to
@uploadthing/react(^7.2.0) anduploadthing(^7.5.0) match the intended release versions mentioned in the PR objectives.Also applies to: 35-35
Line range hint
22-36: Verify dependency compatibility.Let's ensure the updated packages are compatible with other dependencies in the project.
✅ Verification successful
Dependencies are compatible with the project setup
Based on the codebase analysis, the dependencies are compatible:
@uploadthing/react@7.2.0anduploadthing@7.5.0are being used together in multiple example projects and the core packages- The project uses Next.js 15.1.3, which is compatible with these versions of uploadthing
- The codebase shows consistent usage patterns across different implementations (Next.js App Router, Pages Router, etc.)
- The uploadthing configuration in the project follows the latest API patterns seen in the example implementations
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for potential dependency conflicts and peer dependency requirements # Check if there are any conflicting peer dependencies npm info "@uploadthing/react@7.2.0" peerDependencies npm info "uploadthing@7.5.0" peerDependencies # Look for any dependency warnings in package-lock.json if [ -f "package-lock.json" ]; then jq '.packages | .[] | select(.dependencies != null) | select(.dependencies["@uploadthing/react"] != null or .dependencies["uploadthing"] != null)' package-lock.json fiLength of output: 890
Script:
#!/bin/bash # Let's try with the latest available versions to understand the peer dependencies npm info "@uploadthing/react" versions npm info "uploadthing" versions # Also check for any usage of these packages in the codebase rg -l "from ['\"]@uploadthing/react['\"]" --type ts --type tsx rg -l "from ['\"]uploadthing['\"]" --type ts --type tsx # Check Next.js version compatibility by looking at the project configuration fd "next.config" --type f --exec cat {}Length of output: 16932
Script:
#!/bin/bash # Let's check for actual usage of these packages in the codebase rg -l "from ['\"]@uploadthing/react['\"]" rg -l "from ['\"]uploadthing['\"]" # Also check for any configuration files related to uploadthing fd "uploadthing.config" --type f --exec cat {} fd "uploadthing" --type f -e ts -e js --exec cat {}Length of output: 54369
packages/vue/CHANGELOG.md (3)
3-10: LGTM! Changelog entry follows conventions.The changelog entry for version 7.2.0 correctly documents the minor feature addition (custom fetch override) and properly credits the contributor. The version bump follows semantic versioning guidelines for feature additions.
Line range hint
1-280: LGTM! Changelog aligns with PR objectives.The changelog updates are consistent with the PR objectives:
- Version bump to 7.2.0 matches other packages
- Custom fetch override feature is documented
- Part of the coordinated release across the UploadThing ecosystem
🧰 Tools
🪛 LanguageTool
[uncategorized] ~168-~168: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
16-19: Verify peer dependency compatibility with new fetch override feature.The relaxed peer dependency requirements from version 7.1.5 should be verified to ensure they support the new custom fetch override feature in version 7.2.0.
✅ Verification successful
Let me gather more information about the fetch override feature to ensure compatibility.
Let me try a different approach to check the fetch-related changes.
Peer dependency changes are compatible with the codebase
Based on the analysis of package.json files and fetch-related code across the repository:
- All client packages (@uploadthing/vue, @uploadthing/react, @uploadthing/solid, @uploadthing/svelte, @uploadthing/expo) consistently require
uploadthing: ^7.2.0as a peer dependency- The relaxed peer dependency requirements mainly affect framework-specific versions (Vue, React, Solid, Svelte)
- The fetch-related code is properly isolated within each package's implementation
The peer dependency changes in v7.1.5 do not interfere with the fetch override functionality, as the core uploadthing package remains properly versioned across all framework implementations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check peer dependencies in package.json for compatibility # Find and display peer dependencies fd -t f "package.json" -x jq -r '.peerDependencies | select(. != null)'Length of output: 619
Script:
#!/bin/bash # Check for fetch override related changes in recent commits and files rg -l "fetch.*override" --type ts --type vue # Look for any fetch-related configurations or types ast-grep --pattern 'interface $_ { $$$ fetch$_?: $_ $$$ }'Length of output: 141
Script:
#!/bin/bash # Search for fetch-related code in TypeScript files rg -l "fetch" --type ts # Check package versions in package.json files fd -t f "package.json" -x jq -r '{name: .name, version: .version, dependencies: .dependencies, peerDependencies: .peerDependencies} | select(.peerDependencies != null)'Length of output: 4276
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
be7cad0 to
8f6da27
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/react/CHANGELOG.md (1)
258-258: Consider wrapping bare URL in angle brackets.The bare URL on line 258 should be wrapped in angle brackets for better markdown formatting.
- https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 + <https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61>🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (1)
313-313: Consider wrapping bare URLs in angle brackets for better markdown formatting.The following URLs should be wrapped in angle brackets according to markdown best practices:
- https://github.com/Effect-TS/effect/issues/3057 + <https://github.com/Effect-TS/effect/issues/3057> - https://effect.website/docs/guides/observability/logging#built-in-loggers + <https://effect.website/docs/guides/observability/logging#built-in-loggers> - https://docs.uploadthing.com/working-with-files#accessing-files + <https://docs.uploadthing.com/working-with-files#accessing-files> - https://docs.uploadthing.com/getting-started/svelte + <https://docs.uploadthing.com/getting-started/svelte>Also applies to: 487-487, 565-565, 712-712
🧰 Tools
🪛 Markdownlint (0.37.0)
313-313: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (2)
3-10: Consider enhancing the feature description.While the changelog entry follows the standard format, it would be helpful to add more context about the benefits and use cases of the custom fetch override feature.
Consider expanding the description like this:
- feat: allow custom fetch override + feat: allow custom fetch override - enables users to provide their own fetch implementation for better control over network requests and compatibility with different environments
303-304: Fix markdown formatting for the documentation URL.The bare URL should be formatted as a proper markdown link.
Apply this change:
- 📚 Read the docs to get started: - https://docs.uploadthing.com/getting-started/svelte + 📚 Read the [docs](https://docs.uploadthing.com/getting-started/svelte) to get started🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
packages/vue/CHANGELOG.md (1)
7-10: Consider enhancing the feature documentation.While the changelog entry is correct, it could be more helpful to users by including a brief example or more details about the custom fetch override feature, similar to how the "Go to Definition" feature was documented in version 7.1.0 (lines 76-92).
Example enhancement:
- feat: allow custom fetch override + feat: allow custom fetch override - enables users to provide their own fetch implementation for + greater control over the upload process. Example: + ```ts + useUploadThing({ + endpoint: "imageUploader", + fetch: customFetchImplementation, + }) + ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (31)
- packages/vue/package.json
- packages/nuxt/package.json
- examples/with-clerk-remix/package.json
- examples/with-novel/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-appdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-pagedir/package.json
- packages/expo/package.json
- packages/expo/CHANGELOG.md
- examples/minimal-sveltekit/package.json
- packages/svelte/package.json
- examples/minimal-astro-react/package.json
- examples/with-react-image-crop/package.json
- examples/backend-adapters/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-nuxt/package.json
- examples/minimal-tanstack-start/package.json
- examples/profile-picture/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/backend-adapters/server/package.json
- examples/with-serveractions/package.json
- examples/with-drizzle-appdir/package.json
- examples/minimal-expo/package.json
- packages/solid/package.json
- examples/minimal-solidstart/package.json
- packages/uploadthing/package.json
- examples/with-clerk-appdir/package.json
- examples/with-clerk-pagesdir/package.json
- examples/backend-adapters/client-react/package.json
- packages/react/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~137-~137: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/solid/CHANGELOG.md
[uncategorized] ~163-~163: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~247-~247: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/svelte/CHANGELOG.md
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...
(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
258-258: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
304-304: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
313-313: null
Bare URL used
(MD034, no-bare-urls)
487-487: null
Bare URL used
(MD034, no-bare-urls)
565-565: null
Bare URL used
(MD034, no-bare-urls)
712-712: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (10)
packages/solid/CHANGELOG.md (2)
3-10: LGTM! Changelog entry is well-formatted and consistent with PR objectives.The changelog entry for version 7.2.0 correctly documents:
- The minor version bump for the new feature
- The PR reference (feat: add custom fetch override #1099)
- The commit hash
- Proper attribution to @juliusmarminge
- Clear description of the feature (custom fetch override)
This aligns perfectly with the PR objectives which mention this feature being added across multiple packages.
Line range hint
1-155: Well-structured changelog following best practices.The changelog demonstrates excellent maintenance with:
- Clear version headers and change categorization
- Consistent formatting across versions
- Proper linking of PRs and commits
- Detailed tracking of dependency updates
- Clear attribution to contributors
packages/react/CHANGELOG.md (2)
3-10: LGTM! Latest version entry matches PR objectives.The changelog entry for version 7.2.0 correctly documents:
- The minor version bump (7.2.0)
- The feature addition allowing custom fetch override
- Proper attribution to contributor @juliusmarminge
- Link to the relevant PR (feat: add custom fetch override #1099)
Line range hint
1-534: Excellent changelog structure and documentation.The changelog follows best practices:
- Clear version headers with semantic versioning
- Organized sections for Major/Minor/Patch changes
- Consistent linking to PRs and commits
- Proper attribution to contributors
- Detailed descriptions of changes
🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (1)
3-10: LGTM! Well-structured changelog entry.The changelog entry for version 7.5.0 follows the standard format with:
- Clear version number
- Proper categorization (Minor Changes)
- Links to PR (feat: add custom fetch override #1099) and commit hash
- Credit to contributor (@juliusmarminge)
- Clear description of changes
packages/svelte/CHANGELOG.md (1)
Line range hint
1-309: LGTM! Changelog updates align with release strategy.The changelog updates are consistent with the PR objectives, showing this is part of a coordinated release across multiple packages. The version bump to 7.2.0 and the addition of the custom fetch override feature align with the changes in other packages.
🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md (2)
3-10: LGTM! Well-structured changelog entry.The new version entry is properly formatted, includes correct PR reference (#1099), credits the contributor, and clearly describes the feature addition. This is consistent with the coordinated release mentioned in the PR objectives.
Line range hint
11-280: LGTM! Previous entries maintain consistent structure.The historical changelog entries follow proper semantic versioning, maintain consistent formatting, and provide clear documentation of changes with appropriate references to PRs and contributors.
🧰 Tools
🪛 LanguageTool
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM: Changelog entry follows the standard format.The new version entry is properly structured with:
- Clear version number (7.1.6)
- Correct categorization as patch change
- Well-formatted dependency update with commit reference
7-9: Verify dependency update aligns with PR objectives.The update to @uploadthing/vue@7.2.0 aligns with the PR objectives, which indicate this version introduces custom fetch override capability across all packages.
Run this script to verify version consistency across related packages:
✅ Verification successful
Let me gather more information about the dependency update.
Let me gather one final piece of information to check the specific changes in version 7.2.0.
Based on the search results, I can now make a determination about the dependency update verification.
Dependency update to @uploadthing/vue@7.2.0 is correctly aligned with package requirements
The verification shows that:
- The package.json correctly specifies
@uploadthing/vueas a workspace dependency- The CHANGELOG.md properly documents the update to version 7.2.0
- The package is actively used in the codebase:
- Imported and used in module.ts for styles and configuration
- Used in runtime components (dropzone.ts, button.ts)
- Used in composables (useUploadThing.ts)
The update appears to be properly integrated and the version bump is correctly reflected in the dependency declarations and changelog. No issues were found that would impact the package's functionality or integration.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify version consistency in package.json files # Look for @uploadthing/vue dependency version in package.json # Find and check package.json files fd "package.json" packages/nuxt | xargs cat | jq -r '.dependencies["@uploadthing/vue"] // .devDependencies["@uploadthing/vue"]' # Verify the dependency is listed in changesets fd "CHANGELOG.md" packages/nuxt | xargs rg "@uploadthing/vue@7.2.0"Length of output: 237
Script:
#!/bin/bash # Check the actual changes in the PR for this dependency update rg -A 5 "@uploadthing/vue" packages/nuxt # Check if there are any related configuration or usage changes fd . packages/nuxt -e ts -e vue | xargs rg "uploadthing" # Look for any related changeset files fd . .changeset -e md | xargs catLength of output: 10448
Script:
#!/bin/bash # Check for any commit messages or PR descriptions related to this version rg -B 2 -A 2 "7.2.0" . # Look for any configuration changes related to fetch rg -i "fetch" packages/nuxt/srcLength of output: 102775
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
e9bdd26 to
d4f764b
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/expo/CHANGELOG.md (1)
128-131: Add missing comma in fix descriptionMinor formatting improvement needed.
- Thanks [@juraj98](https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function` + Thanks [@juraj98](https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function`,🧰 Tools
🪛 LanguageTool
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md (1)
233-236: Consider maintaining a consistent, professional tone in changelog entriesWhile the addition of Vue and Nuxt support is indeed significant, consider removing the exclamation mark to maintain a consistent, professional tone throughout the changelog.
- Thanks [@markflorkowski](https://github.com/markflorkowski)! - feat: vue and - nuxt support! + Thanks [@markflorkowski](https://github.com/markflorkowski) - feat: vue and + nuxt support🧰 Tools
🪛 LanguageTool
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (31)
- examples/backend-adapters/client-vanilla/package.json
- packages/vue/package.json
- packages/nuxt/package.json
- examples/backend-adapters/server/package.json
- packages/solid/package.json
- examples/minimal-astro-react/package.json
- examples/with-serveractions/package.json
- examples/minimal-solidstart/package.json
- examples/with-react-image-crop/package.json
- packages/uploadthing/package.json
- examples/with-novel/package.json
- examples/minimal-sveltekit/package.json
- examples/minimal-expo/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-remix/package.json
- examples/backend-adapters/client-vue/package.json
- examples/backend-adapters/package.json
- examples/with-tailwindcss/package.json
- examples/with-drizzle-pagesdir/package.json
- packages/svelte/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-drizzle-appdir/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-nuxt/package.json
- packages/solid/CHANGELOG.md
- examples/profile-picture/package.json
- packages/expo/package.json
- examples/minimal-appdir/package.json
- examples/minimal-pagedir/package.json
- packages/react/package.json
- examples/minimal-tanstack-start/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[uncategorized] ~111-~111: You might be missing the article “the” here.
Context: ...! - fix: options was not forwarded to uploadthing handler correctly - Updated dependenci...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~159-~159: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~178-~178: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~289-~289: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~497-~497: You might be missing the article “the” here.
Context: ... UploadButton progress text going under progress bar - Updated dependencies [[`f0a4ae...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
packages/svelte/CHANGELOG.md
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...
(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
258-258: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
304-304: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
313-313: null
Bare URL used
(MD034, no-bare-urls)
487-487: null
Bare URL used
(MD034, no-bare-urls)
565-565: null
Bare URL used
(MD034, no-bare-urls)
712-712: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (9)
packages/expo/CHANGELOG.md (2)
3-16: LGTM! Well-structured changelog entry for version 7.2.0The changelog entry properly documents:
- The minor feature addition (custom fetch override)
- PR reference (feat: add custom fetch override #1099) and commit hash
- Credit to contributor (@juliusmarminge)
- Related dependency updates
Line range hint
83-120: Excellent documentation of the "Go to Definition" featureThe changelog entry for version 7.1.0 provides comprehensive documentation with clear examples of the new feature implementation across different use cases.
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM! Version update follows semver correctlyThe changelog entry for version 7.1.6 properly documents the dependency update to @uploadthing/vue@7.2.0 and follows the conventional format.
74-82: Excellent documentation of the "Go to Definition" feature!The changelog entry provides clear and comprehensive documentation of the feature, including its purpose and usage examples. This significantly enhances developer experience.
packages/vue/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature.
packages/svelte/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature.
packages/react/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature.
packages/uploadthing/CHANGELOG.md (2)
3-10: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature. The version number (7.5.0) differs from the framework packages (7.2.0) which is expected for the core package.
1-1: Overall changelog consistency looks great!The changes are well-coordinated across all packages:
- All framework packages (@uploadthing/vue, @uploadthing/svelte, @uploadthing/react) bumped to 7.2.0
- Core package (uploadthing) bumped to 7.5.0
- All packages consistently document the custom fetch override feature
- All changes are properly linked to PR feat: add custom fetch override #1099 and commit 36b0df6
github-actions
bot
force-pushed
the
changeset-release/main
branch
3 times, most recently
from
d018093 to
5f2ae7f
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (7)
packages/uploadthing/CHANGELOG.md (1)
324-324: Consider wrapping bare URLs in angle brackets.For better markdown linting compliance, consider wrapping bare URLs in angle brackets. For example:
- https://docs.uploadthing.com/working-with-files#accessing-files + <https://docs.uploadthing.com/working-with-files#accessing-files>Also applies to: 498-498, 576-576, 723-723
🧰 Tools
🪛 Markdownlint (0.37.0)
324-324: null
Bare URL used(MD034, no-bare-urls)
packages/nuxt/CHANGELOG.md (1)
233-236: Consider removing redundant exclamation mark.- Thanks [@markflorkowski](https://github.com/markflorkowski)! - feat: vue and nuxt support! + Thanks [@markflorkowski](https://github.com/markflorkowski)! - feat: vue and nuxt support🧰 Tools
🪛 LanguageTool
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md (3)
3-10: Consider enhancing the documentation for JsonArray feature.While the patch change is well-documented with PR and commit references, it would be helpful to include more details about:
- The purpose and use cases of the JsonArray feature
- Examples of supported deeply nested object structures
- Any limitations or considerations when using deeply nested objects
342-343: Improve URL formatting in documentation links.The bare URL should be wrapped in angle brackets for better markdown formatting:
- https://docs.uploadthing.com/getting-started/svelte + <https://docs.uploadthing.com/getting-started/svelte>🧰 Tools
🪛 Markdownlint (0.37.0)
343-343: null
Bare URL used(MD034, no-bare-urls)
167-169: Fix typo in documentation.There's a typo in "Multi Part Uplaods":
- Multi Part Uplaods hasve been abstracted away + Multi Part Uploads have been abstracted awaypackages/react/CHANGELOG.md (1)
263-265: Consider wrapping bare URLs in proper markdown links.For better markdown formatting, consider wrapping the URL in proper markdown syntax:
- https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 + [example](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (1)
309-310: Consider wrapping bare URLs in proper markdown links.For better markdown formatting, consider wrapping the URL in proper markdown syntax:
- https://docs.uploadthing.com/getting-started/svelte + [Read the docs](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (40)
.changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
✅ Files skipped from review due to trivial changes (1)
- packages/shared/package.json
🚧 Files skipped from review as they are similar to previous changes (32)
- examples/backend-adapters/server/package.json
- packages/nuxt/package.json
- examples/with-clerk-remix/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-clerk-appdir/package.json
- packages/solid/package.json
- examples/minimal-nuxt/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-drizzle-appdir/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-serveractions/package.json
- examples/with-clerk-pagesdir/package.json
- examples/minimal-tanstack-start/package.json
- examples/profile-picture/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/expo/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-appdir/package.json
- packages/vue/package.json
- examples/with-tailwindcss/package.json
- examples/with-react-image-crop/package.json
- examples/backend-adapters/package.json
- packages/expo/CHANGELOG.md
- packages/svelte/package.json
- packages/react/package.json
- packages/uploadthing/package.json
- examples/minimal-expo/package.json
- examples/with-novel/package.json
- packages/solid/CHANGELOG.md
- examples/minimal-sveltekit/package.json
- examples/minimal-solidstart/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
324-324: null
Bare URL used
(MD034, no-bare-urls)
498-498: null
Bare URL used
(MD034, no-bare-urls)
576-576: null
Bare URL used
(MD034, no-bare-urls)
723-723: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (4)
packages/uploadthing/CHANGELOG.md (1)
3-21: LGTM! The changelog entry for version 7.5.0 is well structured and informative.The changes are properly categorized into minor and patch changes, with clear references to PR numbers and commit hashes.
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM! Version entry follows changelog conventions.The new version entry correctly documents the dependency update to
@uploadthing/vue@7.2.0following the Changesets format.
Line range hint
1-241: LGTM! Well-maintained changelog with consistent formatting.The changelog maintains excellent traceability with PR links, contributor credits, and detailed descriptions for each change.
packages/vue/CHANGELOG.md (1)
3-16: LGTM! Consistent version bump and changes.The version bump to 7.2.0 and the changes are consistent across all packages. The minor change for custom fetch override and the dependency update to @uploadthing/shared@7.1.6 are properly documented.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (7)
packages/react/CHANGELOG.md (2)
264-264: Consider using a proper Markdown link format.Instead of using a bare URL, consider using proper Markdown link syntax for better readability and maintainability.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +[novel-plugin.ts#L50-L61](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
143-143: Add a comma for better readability.Add a comma after "sometimes" to improve readability of the sentence.
-fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function` +fix vite monorepos sometimes, complaining about `$RefreshSig$ is not a function`🧰 Tools
🪛 LanguageTool
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md (1)
309-310: Use proper Markdown link syntax for the documentation URL.Convert the bare URL to proper Markdown link syntax for better accessibility and consistency.
- 📚 Read the docs to get started: - https://docs.uploadthing.com/getting-started/svelte + 📚 [Read the docs to get started](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/shared/CHANGELOG.md (4)
3-10: LGTM! The changelog entry is well-formatted.The latest version entry (7.1.6) follows the standard changelog format with proper PR reference, commit hash, and clear description of the changes.
Consider adding more details about:
- The previous behavior with deeply nested objects
- Examples of the fixed functionality
- Any breaking changes or migration steps if applicable
342-343: Format bare URLs as markdown links.Convert bare URLs to proper markdown links for better documentation consistency.
-📚 Read the docs to get started: -https://docs.uploadthing.com/getting-started/svelte +📚 Read the docs to get started: [Svelte Documentation](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
343-343: null
Bare URL used(MD034, no-bare-urls)
453-458: Improve error handling documentation reference.Format the error handling documentation reference as a proper markdown link.
-feat: float error messages to client for UploadThingErrors. Read the -[error handling docs 📚](https://docs.uploadthing.com/errors) to find out -more. +feat: float error messages to client for UploadThingErrors. For more information, +see the [Error Handling Documentation 📚](https://docs.uploadthing.com/errors).
167-172: Enhance major version change documentation.The major version change (7.0.0) would benefit from more detailed documentation.
Consider adding:
- A migration guide from version 6.x to 7.0.0
- Code examples showing the changes in implementation
- Performance benchmarks demonstrating the improvements
- Any potential breaking changes that users should be aware of
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (40)
.changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
✅ Files skipped from review due to trivial changes (1)
- packages/shared/package.json
🚧 Files skipped from review as they are similar to previous changes (32)
- examples/with-serveractions/package.json
- packages/nuxt/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/solid/package.json
- examples/backend-adapters/server/package.json
- packages/expo/CHANGELOG.md
- examples/with-drizzle-appdir/package.json
- packages/vue/package.json
- examples/minimal-pagedir/package.json
- examples/with-react-image-crop/package.json
- examples/minimal-expo/package.json
- packages/svelte/package.json
- examples/minimal-astro-react/package.json
- examples/backend-adapters/package.json
- examples/with-clerk-appdir/package.json
- examples/with-tailwindcss/package.json
- examples/with-novel/package.json
- packages/solid/CHANGELOG.md
- packages/expo/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-appdir/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-remix/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-nuxt/package.json
- packages/uploadthing/package.json
- examples/minimal-sveltekit/package.json
- examples/minimal-tanstack-start/package.json
- examples/profile-picture/package.json
- packages/react/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-drizzle-pagesdir/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
324-324: null
Bare URL used
(MD034, no-bare-urls)
498-498: null
Bare URL used
(MD034, no-bare-urls)
576-576: null
Bare URL used
(MD034, no-bare-urls)
723-723: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (10)
packages/react/CHANGELOG.md (1)
3-16: LGTM! The changelog entry for version 7.2.0 is well-structured.The changelog follows the Keep a Changelog format with clear sections for Minor and Patch changes. The PR link (#1099) and commit hash are properly referenced, and credit is given to the contributor (@juliusmarminge).
packages/vue/CHANGELOG.md (2)
3-16: LGTM! Well-structured changelog entry.The new version entry follows the proper changelog format, includes clear attribution, and correctly documents both the minor feature addition and dependency update.
Line range hint
1-286: LGTM! Consistent changelog format maintained.The changelog demonstrates excellent maintenance practices with:
- Consistent formatting across versions
- Clear attribution of changes
- Proper semver versioning
- Detailed documentation of dependencies
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM: Version update follows semantic versioningThe patch version update correctly reflects the dependency update to @uploadthing/vue@7.2.0.
74-82: Excellent documentation of the "Go to Definition" featureThe changelog entry provides clear documentation with practical examples, which greatly helps developers understand and implement the feature.
packages/svelte/CHANGELOG.md (2)
3-16: LGTM! Well-structured changelog entry.The new version entry follows the Keep a Changelog format and properly documents all necessary information including version, changes, PR reference, and attribution.
Line range hint
1-315: LGTM! Consistent and well-maintained changelog.The changelog maintains excellent consistency in formatting and structure throughout its history, making it easy to track changes across versions.
🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (3)
3-11: LGTM! Minor changes are well documented.The changelog entry for version 7.5.0 clearly documents the minor changes:
- Custom fetch override feature (PR feat: add custom fetch override #1099)
- Fix for deeply nested objects with JsonArray (PR fix: allow nested objects in
JsonArraytype #1127)The changes align with the PR objectives and follow the conventional changelog format.
12-18: LGTM! Patch changes are properly documented.The patch changes section clearly documents the fix for handling deeply nested objects when using JsonArray, with proper PR and commit references.
19-21: LGTM! Dependencies are properly updated.The dependency updates section correctly documents the update of @uploadthing/shared to version 7.1.6 with proper commit references.
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
cba93a1 to
c882061
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/react/CHANGELOG.md (1)
264-264: Fix bare URL in markdown.The URL should be properly formatted using markdown link syntax.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +[Example](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (1)
309-310: Consider using markdown link syntax for the documentation URL.While bare URLs are common in changelogs, using markdown link syntax would improve readability:
- https://docs.uploadthing.com/getting-started/svelte + [Svelte Documentation](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (41)
.changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/good-tables-jump.md
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (33)
- packages/nuxt/package.json
- packages/shared/package.json
- examples/with-serveractions/package.json
- packages/solid/package.json
- packages/uploadthing/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/vue/package.json
- examples/backend-adapters/server/package.json
- examples/with-clerk-remix/package.json
- packages/expo/CHANGELOG.md
- examples/profile-picture/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-tanstack-start/package.json
- packages/svelte/package.json
- examples/minimal-expo/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-astro-react/package.json
- examples/with-react-image-crop/package.json
- packages/expo/package.json
- examples/with-drizzle-pagesdir/package.json
- packages/react/package.json
- examples/minimal-sveltekit/package.json
- examples/with-clerk-pagesdir/package.json
- examples/minimal-nuxt/package.json
- examples/minimal-appdir/package.json
- examples/with-novel/package.json
- examples/backend-adapters/package.json
- examples/minimal-solidstart/package.json
- examples/with-clerk-appdir/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-drizzle-appdir/package.json
- packages/solid/CHANGELOG.md
- examples/with-tailwindcss/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/vue/CHANGELOG.md
[uncategorized] ~174-~174: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~249-~249: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
331-331: null
Bare URL used
(MD034, no-bare-urls)
505-505: null
Bare URL used
(MD034, no-bare-urls)
583-583: null
Bare URL used
(MD034, no-bare-urls)
730-730: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (15)
packages/vue/CHANGELOG.md (1)
3-16: LGTM! The changelog entry is well-structured and consistent.The new version entry (7.2.0) follows the conventional commits format and properly documents:
- Minor change: Custom fetch override feature with PR feat: add custom fetch override #1099 reference
- Patch change: Updated dependency @uploadthing/shared to 7.1.6
- Proper attribution to contributor @juliusmarminge
The changes align perfectly with the PR objectives.
packages/react/CHANGELOG.md (1)
Line range hint
1-540: Well-structured changelog that follows best practices.The changelog is well-organized, follows semantic versioning, and provides clear descriptions of changes. Each entry includes:
- Type of change (Minor/Patch)
- PR reference
- Commit hash
- Contributor attribution
- Clear description of the change
🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (2)
3-16: LGTM! Version entry is well-documented.The changelog entry for version 7.2.0 is properly structured with clear sections for Minor and Patch changes, including proper links to PR, commit hash, and credit to the contributor.
Line range hint
1-315: LGTM! Documentation format is consistent.The changelog follows the Keep a Changelog format consistently, with proper categorization of changes and consistent formatting of links.
🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/nuxt/CHANGELOG.md (3)
3-9: LGTM! Version entry follows semver and conventional format.The changelog entry for version 7.1.6 correctly documents the dependency update to
@uploadthing/vue@7.2.0as a patch change.
74-82: Well-documented feature with clear examples!The changelog effectively communicates the "Go to Definition" feature addition, providing clear context and usage examples.
Line range hint
1-241: Excellent changelog structure and maintenance!The changelog consistently follows the Keep a Changelog format, with proper categorization of changes, PR links, commit hashes, and contributor attributions.
packages/uploadthing/CHANGELOG.md (5)
3-4: LGTM! Version number follows semantic versioning.The version number 7.5.0 correctly indicates a minor version bump, which aligns with the introduction of new features without breaking changes.
7-10: LGTM! Clear documentation of the custom fetch override feature.The changelog entry properly references PR #1099 and commit hash, following the standard format. The feature description is concise and clear.
14-19: LGTM! Well-documented error handling improvement.The patch change clearly explains that errors were sometimes silently ignored when they shouldn't have been, providing good context for the fix.
21-24: LGTM! Clear documentation of JsonArray enhancement.The patch change properly documents the addition of support for deeply nested objects when using JsonArray.
26-28: LGTM! Dependency update properly documented.The dependency update to @uploadthing/shared@7.1.6 is correctly referenced with the associated commit hash.
packages/shared/CHANGELOG.md (3)
3-10: LGTM! Improved JSON handling capabilities.The patch introduces support for deeply nested objects in JsonArray, which is a valuable improvement for handling complex data structures.
Line range hint
1-458: Well-documented changelog with clear explanations.The changelog maintains high documentation quality with:
- Consistent formatting
- Clear references to PRs and commits
- Detailed explanations and examples for significant changes
🧰 Tools
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
343-343: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
Line range hint
1-458: Verify cross-package consistency for custom fetch override feature.The changelog shows coordinated releases across multiple packages (@uploadthing/expo, @uploadthing/react, @uploadthing/solid, @uploadthing/svelte, @uploadthing/vue) implementing the custom fetch override feature. Let's verify the implementation consistency.
Run the following script to check the implementation across packages:
🧰 Tools
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
343-343: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
7342f1e to
4fa14e3
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/svelte/CHANGELOG.md (1)
309-310: Format URL as markdown link for better readability.Consider formatting the documentation URL as a markdown link:
- https://docs.uploadthing.com/getting-started/svelte + [https://docs.uploadthing.com/getting-started/svelte](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/vue/CHANGELOG.md (1)
Line range hint
1-286: Excellent changelog maintenance!The changelog demonstrates consistent formatting and comprehensive documentation across all versions. Particularly noteworthy is the detailed explanation provided for significant changes (e.g., the "Go to Definition" feature in version 7.1.0).
A few style suggestions to maintain in future entries:
- Continue linking PRs and commits
- Keep attributing changes to contributors
- Maintain the clear separation between Minor and Patch changes
- Add detailed explanations for significant features
🧰 Tools
🪛 LanguageTool
[uncategorized] ~174-~174: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~249-~249: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/nuxt/CHANGELOG.md (1)
15-18: Consider consistent line wrapping for better readability.Some changelog entries have inconsistent line wrapping. For example:
- Lines 15-18: The description is wrapped across multiple lines
- Lines 60-64: The explanation is split across multiple lines with varying indentation
Consider maintaining a consistent line length and indentation style throughout the changelog for better readability.
Also applies to: 60-64
packages/react/CHANGELOG.md (1)
263-265: Consider using reference-style links for better readability.Instead of bare URLs in the text, consider using Markdown reference-style links. For example:
-💡 See https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 for a live example utilizing these helpers. +💡 See [this example][novel-plugin] for a live example utilizing these helpers. + +[novel-plugin]: https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (42)
.changeset/curvy-rings-own.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (3)
- .changeset/good-tables-jump.md
- .changeset/curvy-rings-own.md
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (33)
- packages/shared/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/backend-adapters/server/package.json
- examples/with-serveractions/package.json
- packages/nuxt/package.json
- packages/solid/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-solidstart/package.json
- examples/with-tailwindcss/package.json
- packages/svelte/package.json
- examples/with-clerk-pagesdir/package.json
- examples/backend-adapters/package.json
- examples/with-novel/package.json
- packages/expo/package.json
- examples/minimal-sveltekit/package.json
- examples/backend-adapters/client-vue/package.json
- examples/profile-picture/package.json
- examples/minimal-pagedir/package.json
- packages/expo/CHANGELOG.md
- packages/react/package.json
- packages/solid/CHANGELOG.md
- packages/vue/package.json
- examples/minimal-expo/package.json
- examples/minimal-appdir/package.json
- examples/with-clerk-remix/package.json
- examples/minimal-nuxt/package.json
- packages/uploadthing/package.json
- examples/minimal-astro-react/package.json
- examples/with-react-image-crop/package.json
- examples/with-drizzle-appdir/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-tanstack-start/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/shared/CHANGELOG.md
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/vue/CHANGELOG.md
[uncategorized] ~174-~174: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~249-~249: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
337-337: null
Bare URL used
(MD034, no-bare-urls)
511-511: null
Bare URL used
(MD034, no-bare-urls)
589-589: null
Bare URL used
(MD034, no-bare-urls)
736-736: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (12)
packages/svelte/CHANGELOG.md (1)
3-16: LGTM! Version entry follows changelog conventions.The version bump to 7.2.0 is appropriate for the new custom fetch override feature, and all changes are properly documented with PR links, commit hashes, and contributor credits.
packages/shared/CHANGELOG.md (1)
3-10: LGTM! Well-documented changelog entry.The changelog entry for version 7.1.6 is properly formatted and includes all necessary information: PR reference, commit hash, contributor credit, and a clear description of the patch change.
packages/vue/CHANGELOG.md (1)
3-16: Well-structured changelog entry for version 7.2.0!The changelog entry follows best practices with proper semantic versioning, clear feature description, PR/commit references, and dependency updates.
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM! Version entry follows the standard format.The changelog entry for version 7.1.6 correctly documents the dependency update to @uploadthing/vue@7.2.0, which aligns with the PR objectives.
74-82: Well-documented feature addition with clear examples.The changelog effectively documents the "Go to Definition" feature addition, providing clear examples and explaining the benefits. This is a good practice for maintaining changelog quality.
packages/react/CHANGELOG.md (2)
3-16: Well-structured version entry!The changelog entry for version 7.2.0 follows best practices by:
- Linking to the PR and commit hash for traceability
- Crediting the contributor
- Clearly categorizing changes as Minor/Patch
Line range hint
77-117: Excellent documentation of significant changes!The changelog effectively documents important changes with:
- Clear migration guides for breaking changes
- Examples of new API usage
- Detailed explanations of new features
Also applies to: 184-188, 218-235
packages/uploadthing/CHANGELOG.md (5)
7-10: LGTM! Custom fetch override feature added.The addition of a custom fetch override feature is a valuable enhancement that provides more flexibility for users. This change was contributed by @juliusmarminge.
14-19: Improved error handling in utapi.Good improvement to prevent silent error suppression. This enhances debugging and error tracking capabilities.
21-24: Support added for deeply nested objects in JsonArray.This enhancement improves the flexibility of the JsonArray feature, allowing for more complex data structures.
32-34: LGTM! Dependency update.The dependency @uploadthing/shared has been updated to version 7.1.6.
26-30: New URL field added with deprecation notice.A new
ufsUrlfield has been introduced with the formathttps://APP_ID.ufs.sh/f/FILE_KEY, whileurlandappUrlfields are being deprecated. This change should be clearly communicated to users to ensure smooth migration.Let's verify the impact of this deprecation:
✅ Verification successful
Deprecation properly implemented with backward compatibility maintained
The deprecation of
urlandappUrlfields has been properly implemented with the newufsUrlfield. The change maintains backward compatibility by:
- Keeping deprecated fields functional
- Adding clear deprecation notices in types
- Including comprehensive test coverage
- Documenting the change in the changelog
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for usage of deprecated url fields # Test: Search for usage of deprecated url and appUrl fields rg -A 2 'url:|appUrl:'Length of output: 35825
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
2d6e17f to
51b3f11
Compare
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
35ff59d to
a95eb94
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (8)
packages/react/CHANGELOG.md (2)
264-264: Use markdown link syntax instead of bare URL.The bare URL should be wrapped in markdown link syntax for better readability and maintainability.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +[Example](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
143-143: Add missing comma for better readability.A comma should be added after "sometimes" to improve readability.
-fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function` +fix vite monorepos sometimes, complaining about `$RefreshSig$ is not a function`🧰 Tools
🪛 LanguageTool
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md (1)
309-310: Format documentation URL using markdown link syntax.Convert the bare URL to proper markdown link syntax for better readability.
- 📚 Read the docs to get started: - https://docs.uploadthing.com/getting-started/svelte + 📚 [Read the docs to get started](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (1)
28-30: Consider adding migration guide for deprecated fields.The changelog mentions deprecation of
urlandappUrlfields in favor ofufsUrl. Consider adding a migration guide or code example to help users transition to the new field.- // Before - const fileUrl = file.url; // or file.appUrl + // After + const fileUrl = file.ufsUrl; // https://APP_ID.ufs.sh/f/FILE_KEYpackages/shared/CHANGELOG.md (1)
214-214: Convert bare URLs to markdown links for better formatting.There are a few instances where bare URLs are used instead of proper markdown links. Consider converting them to markdown format for better readability and maintainability.
For example, convert:
-https://github.com/Effect-TS/effect/issues/3057 +[Effect-TS/effect#3057](https://github.com/Effect-TS/effect/issues/3057) -https://docs.uploadthing.com/getting-started/svelte +[Svelte Getting Started Guide](https://docs.uploadthing.com/getting-started/svelte)Also applies to: 343-343
🧰 Tools
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
packages/vue/CHANGELOG.md (1)
3-16: Consider enhancing the feature documentation.The changelog entry for the custom fetch override feature would benefit from additional details:
- Usage examples
- Common use cases
- Any limitations or considerations
Example addition:
### Minor Changes - [#1099](https://github.com/pingdotgg/uploadthing/pull/1099) [`36b0df6`](https://github.com/pingdotgg/uploadthing/commit/36b0df6c3b94358d1a12112d661bc561256cc98e) Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - feat: allow custom fetch override + + You can now provide a custom fetch implementation: + ```ts + useUploadThing({ + endpoint: "imageUploader", + fetch: customFetchImplementation, + }); + ```packages/nuxt/CHANGELOG.md (2)
3-9: Consider adding context about the custom fetch override feature.While the dependency update is correctly documented, consider mentioning that this update brings in the custom fetch override feature from @uploadthing/vue@7.2.0 to provide more context about the significance of this update.
## 7.1.6 ### Patch Changes - Updated dependencies [[`36b0df6`](https://github.com/pingdotgg/uploadthing/commit/36b0df6c3b94358d1a12112d661bc561256cc98e)]: - - @uploadthing/vue@7.2.0 + - @uploadthing/vue@7.2.0 // Adds support for custom fetch override
108-111: Enhance the fix description with more context.The fix description for options forwarding could be more helpful by explaining what options were affected and the impact of this fix.
- [#1018](https://github.com/pingdotgg/uploadthing/pull/1018) [`06c6787`](https://github.com/pingdotgg/uploadthing/commit/06c6787aacb7bf52919c1c767bef8b315010725c) - Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - fix: options - was not forwarded to uploadthing handler correctly + Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - fix: configuration + options (e.g., endpoint, onUploadBegin) were not being properly forwarded to the + uploadthing handler, causing custom configurations to be ignored🧰 Tools
🪛 LanguageTool
[uncategorized] ~111-~111: You might be missing the article “the” here.
Context: ...! - fix: options was not forwarded to uploadthing handler correctly - Updated dependenci...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (43)
.changeset/curvy-rings-own.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (4)
- .changeset/curvy-rings-own.md
- .changeset/good-tables-jump.md
- .changeset/purple-shrimps-chew.md
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (33)
- packages/shared/package.json
- packages/nuxt/package.json
- examples/backend-adapters/server/package.json
- packages/solid/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-serveractions/package.json
- examples/minimal-astro-react/package.json
- packages/uploadthing/package.json
- examples/minimal-nuxt/package.json
- packages/svelte/package.json
- examples/with-novel/package.json
- examples/with-tailwindcss/package.json
- examples/backend-adapters/package.json
- examples/with-react-image-crop/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-clerk-appdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-clerk-remix/package.json
- packages/vue/package.json
- packages/expo/CHANGELOG.md
- examples/minimal-expo/package.json
- examples/minimal-appdir/package.json
- examples/minimal-sveltekit/package.json
- examples/with-drizzle-appdir/package.json
- examples/backend-adapters/client-vue/package.json
- packages/expo/package.json
- packages/solid/CHANGELOG.md
- examples/profile-picture/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-tanstack-start/package.json
- examples/backend-adapters/client-react/package.json
- packages/react/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[uncategorized] ~111-~111: You might be missing the article “the” here.
Context: ...! - fix: options was not forwarded to uploadthing handler correctly - Updated dependenci...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~159-~159: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...re: update paths to new api domain Previously the SDK version was just sent in the he...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~180-~180: The preposition “to” seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
337-337: null
Bare URL used
(MD034, no-bare-urls)
511-511: null
Bare URL used
(MD034, no-bare-urls)
589-589: null
Bare URL used
(MD034, no-bare-urls)
736-736: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (10)
packages/react/CHANGELOG.md (1)
3-16: LGTM! Well-structured changelog entry.The latest version entry follows the Keep a Changelog format with clear sections for Minor and Patch changes, proper PR/commit links, and contributor attribution.
packages/svelte/CHANGELOG.md (2)
3-16: LGTM! Well-structured changelog entry.The changelog entry for version 7.2.0 is well-documented with proper categorization, PR/commit references, and contributor attribution.
Line range hint
1-315: LGTM! Consistent documentation style.The changelog maintains consistent formatting and structure throughout, with clear version separation and proper markdown hierarchy.
🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (3)
3-4: LGTM! Version header follows semantic versioning.The version number and structure follow the standard changelog format.
7-30: LGTM! Minor changes are well documented.The minor changes section properly documents:
- Custom fetch override feature (PR feat: add custom fetch override #1099)
- Error handling improvements in utapi
- Support for deeply nested objects in JsonArray
- New ufsUrl field with deprecation notice for url and appUrl fields
32-34: LGTM! Dependency updates are properly tracked.The patch changes section correctly documents the dependency update for @uploadthing/shared to version 7.1.6.
packages/shared/CHANGELOG.md (2)
3-10: LGTM! Version 7.1.6 changelog entry is well-formatted.The changelog entry follows the conventional format and clearly documents:
- The version number
- The type of change (Patch)
- The PR reference (fix: allow nested objects in
JsonArraytype #1127)- The commit hash
- The contributor acknowledgment
- A clear description of the fix
Line range hint
1-624: Excellent changelog maintenance!The changelog follows best practices:
- Semantic versioning is properly followed
- Breaking changes are clearly marked
- Dependencies are well tracked
- Changes are properly categorized
- Contributors are acknowledged
🧰 Tools
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
343-343: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...re: update paths to new api domain Previously the SDK version was just sent in the he...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~180-~180: The preposition “to” seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
[uncategorized] ~417-~417: You might be missing the article “the” here.
Context: ...fiers when uploading files also adds ability for UTApi methods to filter based on cu...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
packages/vue/CHANGELOG.md (2)
77-85: Excellent documentation for the "Go to Definition" feature!The changelog entry provides clear examples and explains the benefits of the feature. This level of detail helps users understand and adopt new features effectively.
Line range hint
1-286: Well-maintained changelog following best practices!The changelog demonstrates excellent documentation practices:
- Proper semantic versioning
- Clear categorization of changes
- Consistent formatting
- Proper attribution to contributors
- Linked references to PRs and commits
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
85da0a9 to
351423d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
packages/react/CHANGELOG.md (1)
264-264: Format the bare URL as a proper markdown link.The bare URL in the documentation should be formatted as a proper markdown link for better readability and to follow markdown best practices.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +[Example](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (2)
3-16: Consider enhancing the changelog entry with more details.While the changelog entry follows the proper format, the feature description "feat: allow custom fetch override" could be more descriptive to help users understand the feature's purpose and usage.
Consider expanding the description to something like:
- feat: allow custom fetch override + feat: allow custom fetch override to enable custom request handling and better integration with different environments
309-310: Convert bare URL to markdown link.The documentation URL should be formatted as a markdown link for better readability and to comply with markdown best practices.
- https://docs.uploadthing.com/getting-started/svelte + [https://docs.uploadthing.com/getting-started/svelte](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/vue/CHANGELOG.md (1)
7-10: Consider adding migration notes for the custom fetch override feature.To help users adopt the new feature, consider adding a brief example or migration guide demonstrating how to implement the custom fetch override.
Example addition:
Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - feat: allow custom fetch override + + Example usage: + ```ts + useUploadThing({ + endpoint: "myEndpoint", + fetch: customFetchImplementation, + }) + ```packages/shared/CHANGELOG.md (1)
342-343: Improve markdown formatting for URLs.Wrap bare URLs in angle brackets to comply with markdown best practices.
-📚 Read the docs to get started: -https://docs.uploadthing.com/getting-started/svelte +📚 Read the docs to get started: +<https://docs.uploadthing.com/getting-started/svelte>🧰 Tools
🪛 Markdownlint (0.37.0)
343-343: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (44)
.changeset/curvy-rings-own.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-react-router/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (4)
- .changeset/curvy-rings-own.md
- .changeset/nice-penguins-grow.md
- .changeset/good-tables-jump.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (33)
- packages/nuxt/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/uploadthing/package.json
- packages/shared/package.json
- examples/backend-adapters/server/package.json
- examples/with-react-image-crop/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-serveractions/package.json
- packages/solid/package.json
- packages/vue/package.json
- packages/svelte/package.json
- examples/with-novel/package.json
- examples/minimal-expo/package.json
- examples/minimal-solidstart/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-pagedir/package.json
- examples/backend-adapters/client-react/package.json
- examples/minimal-nuxt/package.json
- examples/minimal-sveltekit/package.json
- examples/with-drizzle-appdir/package.json
- examples/minimal-astro-react/package.json
- examples/profile-picture/package.json
- packages/react/package.json
- examples/minimal-appdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/backend-adapters/package.json
- packages/expo/CHANGELOG.md
- packages/solid/CHANGELOG.md
- examples/minimal-tanstack-start/package.json
- examples/with-clerk-remix/package.json
- examples/with-clerk-appdir/package.json
- packages/expo/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~184-~184: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~295-~295: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~503-~503: You might be missing the article “the” here.
Context: ... UploadButton progress text going under progress bar - Updated dependencies [[`f0a4ae...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
packages/shared/CHANGELOG.md
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/vue/CHANGELOG.md
[uncategorized] ~174-~174: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~249-~249: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
337-337: null
Bare URL used
(MD034, no-bare-urls)
511-511: null
Bare URL used
(MD034, no-bare-urls)
589-589: null
Bare URL used
(MD034, no-bare-urls)
736-736: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (11)
packages/react/CHANGELOG.md (1)
3-16: LGTM! Well-structured changelog entry for version 7.2.0.The changelog entry clearly documents:
- The minor change allowing custom fetch override
- The patch change updating the shared dependency
examples/with-clerk-react-router/package.json (1)
16-16: Version updates are consistent with release objectives.The dependency updates align with the PR objectives:
@uploadthing/react@7.2.0: Includes the custom fetch override featureuploadthing@7.5.0: Includes the custom fetch override feature and additional improvementsAlso applies to: 22-22
packages/nuxt/CHANGELOG.md (1)
3-9: Changelog entry is properly formatted and consistent.The new version entry follows the established format and correctly documents the dependency update to
@uploadthing/vue@7.2.0.packages/svelte/CHANGELOG.md (1)
Line range hint
1-315: Well-structured changelog with consistent formatting.The changelog follows best practices:
- Proper semantic versioning
- Clear categorization of changes
- Consistent formatting
- Proper attribution to contributors
🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/vue/CHANGELOG.md (2)
3-16: LGTM! Version entry follows semantic versioning.The changelog entry properly documents the minor version bump for the new custom fetch override feature and includes appropriate attribution and dependency updates.
Line range hint
18-286: LGTM! Previous entries maintain consistent format.The changelog history is well-maintained with proper versioning, PR references, commit links, and contributor attributions.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~174-~174: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~249-~249: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md (3)
3-10: LGTM! The changelog entry follows the conventional format.The patch version increment (7.1.6) is appropriate for a bug fix that allows deeply nested objects in JsonArray, as it maintains backward compatibility.
1-1: LGTM! Semantic versioning is properly followed.The changelog correctly uses:
- Major versions for breaking changes (7.0.0)
- Minor versions for new features (7.1.0, 7.2.0)
- Patch versions for bug fixes (7.1.6)
9-10: Consider adding more context to the JsonArray change.The changelog entry "fix: allow deeply nested objects when using JsonArray" would benefit from additional context explaining:
- What was the previous limitation?
- What types of nested objects are now supported?
- Are there any performance implications?
Would you like me to help draft a more detailed changelog entry?
packages/uploadthing/CHANGELOG.md (2)
3-34: LGTM! Well-structured changelog entry for version 7.5.0.The changelog follows semantic versioning principles with clear categorization of changes into Minor and Patch sections. Each change is properly linked to its corresponding PR and commit, making it easy to track the source of changes.
40-48: LGTM! Clear documentation of dependency updates.The patch changes appropriately document the relaxation of peer dependency requirements between uploadthing packages, with proper links to the PR and commit for reference.
| - [#1128](https://github.com/pingdotgg/uploadthing/pull/1128) | ||
| [`e7ccec9`](https://github.com/pingdotgg/uploadthing/commit/e7ccec9c7fe31618a3bae1962608650f7d91d5a9) | ||
| Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - chore: add new | ||
| `ufsUrl` field with `https://APP_ID.ufs.sh/f/FILE_KEY` url. deprecated `url` | ||
| and `appUrl` fields. |
There was a problem hiding this comment.
💡 Codebase verification
Migration required for URL field deprecation
The deprecation of url and appUrl fields requires attention in several areas:
- Update code that directly accesses these fields to use
ufsUrlinstead - Review and update documentation examples
- Consider adding migration notes to your changelog
The change is well-supported with deprecation warnings and backward compatibility, allowing for a gradual transition to the new field.
🔗 Analysis chain
Verify the impact of URL field deprecation.
A new ufsUrl field has been introduced while url and appUrl fields are being deprecated. This change might affect existing code that relies on these fields.
Run the following script to find usages of the deprecated fields:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Find usages of deprecated url and appUrl fields
# Test: Search for field usage in code. Expect: Instances where these fields are used.
echo "Searching for deprecated field usages..."
rg -A 2 'url: |appUrl: ' || echo "No direct field usage found"
echo "Searching for field access..."
rg -A 2 '\.url|\.appUrl' || echo "No field access found"
Length of output: 61763
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
0a914b9 to
915de23
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/expo/CHANGELOG.md (1)
Line range hint
130-221: Fix typo in version 7.0.3 changelog entry.The changelog entries are well-documented, but there's a minor grammatical issue in the 7.0.3 entry.
Apply this diff to fix the typo:
- Thanks [@juraj98](https://github.com/juraj98)! - fix vite monorepos sometimes + Thanks [@juraj98](https://github.com/juraj98)! - fix vite monorepos, sometimespackages/shared/CHANGELOG.md (1)
214-214: Consider wrapping bare URLs in markdown links.For better markdown formatting, consider wrapping the bare URLs in proper markdown link syntax.
For example:
- See upstream issue: https://github.com/Effect-TS/effect/issues/3057 + See upstream issue: [Effect-TS/effect#3057](https://github.com/Effect-TS/effect/issues/3057) - https://docs.uploadthing.com/getting-started/svelte + [https://docs.uploadthing.com/getting-started/svelte](https://docs.uploadthing.com/getting-started/svelte)Also applies to: 343-343
🧰 Tools
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (1)
337-337: Fix bare URLs in changelogSeveral bare URLs were found in the changelog. These should be wrapped in angle brackets or formatted as proper Markdown links for better compatibility and readability.
Apply these changes:
- https://effect.website/docs/guides/observability/logging#built-in-loggers + <https://effect.website/docs/guides/observability/logging#built-in-loggers> - https://github.com/Effect-TS/effect/issues/3057 + <https://github.com/Effect-TS/effect/issues/3057> - https://docs.uploadthing.com/working-with-files#accessing-files + <https://docs.uploadthing.com/working-with-files#accessing-files> - https://docs.uploadthing.com/getting-started/svelte + <https://docs.uploadthing.com/getting-started/svelte>Also applies to: 511-511, 589-589, 736-736
🧰 Tools
🪛 Markdownlint (0.37.0)
337-337: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (44)
.changeset/curvy-rings-own.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-react-router/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (4)
- .changeset/curvy-rings-own.md
- .changeset/nice-penguins-grow.md
- .changeset/good-tables-jump.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (33)
- packages/vue/package.json
- packages/shared/package.json
- packages/nuxt/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-novel/package.json
- examples/with-serveractions/package.json
- examples/minimal-sveltekit/package.json
- examples/minimal-astro-react/package.json
- packages/svelte/package.json
- packages/solid/package.json
- examples/minimal-appdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-clerk-remix/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-react-image-crop/package.json
- examples/minimal-solidstart/package.json
- examples/with-clerk-pagesdir/package.json
- examples/backend-adapters/server/package.json
- examples/minimal-pagedir/package.json
- examples/with-clerk-react-router/package.json
- packages/expo/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-tailwindcss/package.json
- examples/backend-adapters/package.json
- examples/minimal-nuxt/package.json
- examples/with-clerk-appdir/package.json
- packages/uploadthing/package.json
- examples/with-drizzle-appdir/package.json
- examples/profile-picture/package.json
- examples/minimal-expo/package.json
- examples/minimal-tanstack-start/package.json
- packages/solid/CHANGELOG.md
- packages/react/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
337-337: null
Bare URL used
(MD034, no-bare-urls)
511-511: null
Bare URL used
(MD034, no-bare-urls)
589-589: null
Bare URL used
(MD034, no-bare-urls)
736-736: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (9)
packages/nuxt/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is accurate and well-formatted.The patch version bump to 7.1.6 correctly reflects the dependency update to @uploadthing/vue@7.2.0.
packages/vue/CHANGELOG.md (1)
3-17: LGTM! Changelog entry is accurate and well-formatted.The minor version bump to 7.2.0 correctly reflects:
- New feature: custom fetch override
- Dependency update: @uploadthing/shared@7.1.6
packages/svelte/CHANGELOG.md (1)
3-17: LGTM! Changelog entry is accurate and well-formatted.The minor version bump to 7.2.0 correctly reflects:
- New feature: custom fetch override
- Dependency update: @uploadthing/shared@7.1.6
packages/react/CHANGELOG.md (1)
3-17: LGTM! Changelog entry is accurate and well-formatted.The minor version bump to 7.2.0 correctly reflects:
- New feature: custom fetch override
- Dependency update: @uploadthing/shared@7.1.6
packages/expo/CHANGELOG.md (2)
3-18: LGTM! Version 7.2.0 changelog entry is well-documented.The changelog entry properly documents:
- The minor change introducing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies with their respective versions and commit references
Line range hint
19-122: LGTM! Recent version entries (7.1.x) are well-documented.The changelog entries properly document all changes with:
- Clear descriptions of changes
- PR references and commit hashes
- Proper categorization of changes (Minor/Patch)
- Detailed examples where necessary (e.g., "Go to Definition" feature in 7.1.0)
packages/shared/CHANGELOG.md (2)
3-10: LGTM! Well-structured changelog entry.The changelog entry follows best practices with proper versioning, categorization, links to PR/commit, contributor attribution, and a clear description of changes.
Line range hint
1-624: Excellent documentation quality and change tracking.The changelog demonstrates high-quality documentation practices:
- Clear categorization of changes (Major/Minor/Patch)
- Detailed descriptions of significant changes
- Code examples for complex features
- Proper tracking of dependency updates
- Clear marking of breaking changes
🧰 Tools
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
343-343: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove@effect/schemafrom client bundle resulting in up to 15kB less JS shipped...(AI_HYDRA_LEO_MISSING_COMMA)
packages/uploadthing/CHANGELOG.md (1)
26-30: Migration required for URL field deprecationThe deprecation of
urlandappUrlfields requires attention in several areas:
- Update code that directly accesses these fields to use
ufsUrlinstead- Review and update documentation examples
- Consider adding migration notes to your changelog
The change is well-supported with deprecation warnings and backward compatibility, allowing for a gradual transition to the new field.
✅ Verification successful
Deprecation is properly handled with clear migration path
The codebase already includes:
- Deprecation warnings for both
urlandappUrlfields- The new
ufsUrlfield alongside deprecated fields for backward compatibility- Clear messaging that these fields will be removed in v9
No immediate action required as the deprecation is being handled gracefully with proper warnings and migration guidance.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Find usages of deprecated url and appUrl fields # Test: Search for field usage in code. Expect: Instances where these fields are used. echo "Searching for deprecated field usages..." rg -A 2 'url: |appUrl: ' || echo "No direct field usage found" echo "Searching for field access..." rg -A 2 '\.url|\.appUrl' || echo "No field access found"Length of output: 60146
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
79b64a4 to
c351c56
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/shared/CHANGELOG.md (3)
3-10: Consider enhancing the documentation for version 7.1.6While the changelog entry follows good practices, it would be more helpful to users if it included:
- The impact of allowing deeply nested objects in JsonArray
- Whether there are any breaking changes
- Migration steps if necessary
181-182: Fix minor formatting issuesThere are a few formatting inconsistencies:
- Remove extra spaces in "...flexibility to make changes to the API without needing..."
- Add a missing comma after "bundle" in "...from client bundle resulting in..."
-This change improves our flexibility to make changes to the API without needing +This change improves our flexibility to make changes to the API without needing -from client bundle resulting in up to 15kB less JS shipped +from client bundle, resulting in up to 15kB less JS shippedAlso applies to: 265-265
🧰 Tools
🪛 LanguageTool
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
214-214: Use proper markdown link syntax for URLsConvert bare URLs to proper markdown links for better readability:
-See upstream issue: https://github.com/Effect-TS/effect/issues/3057 +See upstream issue: [Effect-TS/effect#3057](https://github.com/Effect-TS/effect/issues/3057) -https://docs.uploadthing.com/getting-started/svelte +[https://docs.uploadthing.com/getting-started/svelte](https://docs.uploadthing.com/getting-started/svelte)Also applies to: 343-343
🧰 Tools
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (1)
309-310: Fix the bare URL in the documentation.The URL should be wrapped in angle brackets or made into a proper markdown link.
-https://docs.uploadthing.com/getting-started/svelte +<https://docs.uploadthing.com/getting-started/svelte>🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/react/CHANGELOG.md (1)
264-264: Fix the bare URL in the documentation.The URL should be wrapped in angle brackets or made into a proper markdown link.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +<https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61>🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (44)
.changeset/curvy-rings-own.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-react-router/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (4)
- .changeset/good-tables-jump.md
- .changeset/curvy-rings-own.md
- .changeset/nice-penguins-grow.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (32)
- packages/vue/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/nuxt/package.json
- examples/with-serveractions/package.json
- packages/shared/package.json
- examples/backend-adapters/server/package.json
- examples/backend-adapters/client-react/package.json
- packages/solid/package.json
- examples/minimal-expo/package.json
- examples/with-react-image-crop/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-tailwindcss/package.json
- examples/with-clerk-remix/package.json
- examples/with-novel/package.json
- examples/backend-adapters/client-vue/package.json
- packages/uploadthing/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-astro-react/package.json
- packages/svelte/package.json
- examples/backend-adapters/package.json
- examples/minimal-sveltekit/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-clerk-react-router/package.json
- examples/minimal-nuxt/package.json
- examples/profile-picture/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-appdir/package.json
- examples/minimal-tanstack-start/package.json
- packages/react/package.json
- packages/expo/package.json
- examples/with-drizzle-appdir/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/shared/CHANGELOG.md
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/solid/CHANGELOG.md
[uncategorized] ~169-~169: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
337-337: null
Bare URL used
(MD034, no-bare-urls)
511-511: null
Bare URL used
(MD034, no-bare-urls)
589-589: null
Bare URL used
(MD034, no-bare-urls)
736-736: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (12)
packages/nuxt/CHANGELOG.md (2)
3-9: LGTM! Version bump and dependency update are consistent.The changelog entry correctly documents:
- Patch version bump to 7.1.6
- Updated dependency on @uploadthing/vue to version 7.2.0
This aligns with the PR objectives.
Line range hint
1-241: LGTM! Changelog structure is well-maintained.The changelog follows consistent formatting with proper version entries, change types, PR references, commit links, and contributor credits.
packages/shared/CHANGELOG.md (1)
Line range hint
1-599: LGTM! The changelog is well-maintainedThe changelog follows good practices:
- Clear version numbering following semver
- Proper categorization of changes (Major/Minor/Patch)
- Links to PRs and commits
- Credits to contributors
- Clear descriptions of changes
🧰 Tools
🪛 LanguageTool
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove@effect/schemafrom client bundle resulting in up to 15kB less JS shipped...(AI_HYDRA_LEO_MISSING_COMMA)
🪛 Markdownlint (0.37.0)
214-214: null
Bare URL used(MD034, no-bare-urls)
343-343: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (4)
7-10: LGTM: Custom fetch override feature added.The addition of a custom fetch override feature is well-documented and properly credited to @juliusmarminge.
14-19: LGTM: Improved error handling in utapi.The patch fixes an important issue where errors were being silently ignored when they shouldn't have been. This improves error visibility and debugging.
32-34: LGTM: Dependency update.The dependency update to @uploadthing/shared@7.1.6 is properly documented.
26-30: Consider adding migration guide for URL field deprecation.The deprecation of
urlandappUrlfields in favor of the newufsUrlfield may require users to update their code. Consider adding a migration guide to help users transition smoothly.Let's check for any documentation or migration guides:
packages/expo/CHANGELOG.md (1)
3-18: LGTM! The changelog entry for version 7.2.0 is well documented.The changelog properly documents:
- The minor change allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies including @uploadthing/shared@7.1.6
packages/vue/CHANGELOG.md (1)
3-17: LGTM! The changelog entry for version 7.2.0 is consistent with other packages.The changelog properly documents:
- The minor change allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies including @uploadthing/shared@7.1.6
packages/svelte/CHANGELOG.md (1)
3-17: LGTM! The changelog entry for version 7.2.0 maintains consistency.The changelog properly documents:
- The minor change allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies including @uploadthing/shared@7.1.6
packages/solid/CHANGELOG.md (1)
3-17: LGTM! The changelog entry for version 7.2.0 follows the established pattern.The changelog properly documents:
- The minor change allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies including @uploadthing/shared@7.1.6
packages/react/CHANGELOG.md (1)
3-17: LGTM! The changelog entry for version 7.2.0 completes the consistent updates across all packages.The changelog properly documents:
- The minor change allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependencies including @uploadthing/shared@7.1.6
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
c0032ab to
ea46243
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/shared/CHANGELOG.md (1)
167-169: Fix typos in changelog entries.There are a few typos in the changelog that should be corrected:
- "hasve" should be "have"
- Remove extra space between sentences
- Multi Part Uplaods hasve been abstracted away and files are now uploaded as a + Multi Part Uploads have been abstracted away and files are now uploaded as a single stream to UploadThing, reducing the manual steps required to upload files and improves performance. - Polling has been removed in favor of a streaming upload process with instant - feedback + Polling has been removed in favor of a streaming upload process with instant feedbackAlso applies to: 171-172
packages/nuxt/CHANGELOG.md (1)
Line range hint
1-241: Verify changelog format consistency.The changelog follows the Changesets format but some entries could be improved:
- Version 7.1.0 has detailed examples that might be better suited for documentation
- Some entries have inconsistent spacing between sections
Consider standardizing the changelog format:
- Keep entries concise and focused on changes
- Move detailed examples to documentation
- Maintain consistent spacing between sections
packages/react/CHANGELOG.md (1)
3-16: Consider enhancing the documentation for the custom fetch override feature.The changelog entry for version 7.2.0 could be more helpful by including a brief example of how to use the new custom fetch override feature. This would make it easier for users to understand and implement the change.
Consider adding usage examples like:
### Minor Changes - [#1099](https://github.com/pingdotgg/uploadthing/pull/1099) [`36b0df6`](https://github.com/pingdotgg/uploadthing/commit/36b0df6c3b94358d1a12112d661bc561256cc98e) Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - feat: allow custom fetch override + + Example usage: + ```ts + useUploadThing("endpoint", { + customFetch: async (url, options) => { + // Your custom fetch logic here + return fetch(url, options); + } + }); + ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (44)
.changeset/curvy-rings-own.md(0 hunks).changeset/good-tables-jump.md(0 hunks).changeset/nice-penguins-grow.md(0 hunks).changeset/purple-shrimps-chew.md(0 hunks)examples/backend-adapters/client-react/package.json(1 hunks)examples/backend-adapters/client-vanilla/package.json(1 hunks)examples/backend-adapters/client-vue/package.json(1 hunks)examples/backend-adapters/package.json(1 hunks)examples/backend-adapters/server/package.json(1 hunks)examples/minimal-appdir/package.json(1 hunks)examples/minimal-astro-react/package.json(1 hunks)examples/minimal-expo/package.json(2 hunks)examples/minimal-nuxt/package.json(1 hunks)examples/minimal-pagedir/package.json(1 hunks)examples/minimal-solidstart/package.json(1 hunks)examples/minimal-sveltekit/package.json(1 hunks)examples/minimal-tanstack-start/package.json(1 hunks)examples/profile-picture/package.json(2 hunks)examples/with-clerk-appdir/package.json(1 hunks)examples/with-clerk-pagesdir/package.json(1 hunks)examples/with-clerk-react-router/package.json(1 hunks)examples/with-clerk-remix/package.json(1 hunks)examples/with-drizzle-appdir/package.json(1 hunks)examples/with-drizzle-pagesdir/package.json(1 hunks)examples/with-novel/package.json(2 hunks)examples/with-react-image-crop/package.json(1 hunks)examples/with-serveractions/package.json(1 hunks)examples/with-tailwindcss/package.json(1 hunks)packages/expo/CHANGELOG.md(4 hunks)packages/expo/package.json(1 hunks)packages/nuxt/CHANGELOG.md(7 hunks)packages/nuxt/package.json(1 hunks)packages/react/CHANGELOG.md(5 hunks)packages/react/package.json(1 hunks)packages/shared/CHANGELOG.md(3 hunks)packages/shared/package.json(1 hunks)packages/solid/CHANGELOG.md(5 hunks)packages/solid/package.json(1 hunks)packages/svelte/CHANGELOG.md(4 hunks)packages/svelte/package.json(1 hunks)packages/uploadthing/CHANGELOG.md(10 hunks)packages/uploadthing/package.json(1 hunks)packages/vue/CHANGELOG.md(4 hunks)packages/vue/package.json(1 hunks)
💤 Files with no reviewable changes (4)
- .changeset/curvy-rings-own.md
- .changeset/good-tables-jump.md
- .changeset/nice-penguins-grow.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (36)
- packages/nuxt/package.json
- packages/shared/package.json
- examples/with-serveractions/package.json
- packages/solid/package.json
- packages/vue/package.json
- examples/minimal-expo/package.json
- examples/backend-adapters/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/minimal-tanstack-start/package.json
- examples/backend-adapters/server/package.json
- packages/uploadthing/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-sveltekit/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-novel/package.json
- examples/minimal-appdir/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-pagedir/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-react-image-crop/package.json
- examples/with-drizzle-appdir/package.json
- packages/expo/package.json
- examples/with-clerk-appdir/package.json
- examples/profile-picture/package.json
- examples/with-clerk-remix/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-nuxt/package.json
- examples/backend-adapters/client-react/package.json
- packages/expo/CHANGELOG.md
- packages/svelte/package.json
- packages/svelte/CHANGELOG.md
- examples/with-clerk-react-router/package.json
- packages/react/package.json
- packages/solid/CHANGELOG.md
- packages/uploadthing/CHANGELOG.md
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...re: update paths to new api domain Previously the SDK version was just sent in the he...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~180-~180: The preposition “to” seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🔇 Additional comments (6)
packages/vue/CHANGELOG.md (3)
3-16: LGTM! Version bump and changelog entry are consistent with PR objectives.The changelog entry for version 7.2.0 correctly documents:
- The minor feature addition allowing custom fetch override (PR feat: add custom fetch override #1099)
- Updated dependency on @uploadthing/shared@7.1.6
This aligns with the PR objectives which indicate a coordinated release across multiple packages.
22-28: LGTM! Previous version entry provides good context.The changelog entry for version 7.1.5 properly documents the relaxation of peer dependency requirements, which helps understand the package's evolution.
Line range hint
1-286: LGTM! Changelog format follows best practices.The changelog maintains consistent formatting throughout with:
- Clear version headers
- Proper categorization of changes (Minor/Patch)
- Complete reference information (PRs, commits, contributors)
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md (1)
3-10: LGTM! The changelog entry follows the Keep a Changelog format.The new version 7.1.6 is properly documented with:
- Clear reference to PR fix: allow nested objects in
JsonArraytype #1127- Descriptive commit hash
- Credit to contributor
- Concise description of the fix
packages/nuxt/CHANGELOG.md (1)
3-9: LGTM! Version bump aligns with PR objectives.The dependency update to
@uploadthing/vue@7.2.0is consistent with the PR objectives, which mention version updates across multiple packages.packages/react/CHANGELOG.md (1)
Line range hint
1-540: Well-structured changelog format.The changelog follows best practices with:
- Clear version numbering
- Proper categorization of changes (Minor, Patch)
- Consistent linking to PRs and commits
- Credit to contributors
- Dependency updates tracking
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@uploadthing/expo@7.2.0
Minor Changes
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e,36b0df6]:@uploadthing/react@7.2.0
Minor Changes
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e]:@uploadthing/solid@7.2.0
Minor Changes
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e]:@uploadthing/svelte@7.2.0
Minor Changes
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e]:uploadthing@7.5.0
Minor Changes
#1138
ad75280Thanks @juliusmarminge! - feat: add
tailwind v4 css plugin
Usage:
#1099
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
#1125
aab8ab6Thanks @juliusmarminge! - fix: improve
error handling in utapi
sometimes errors got silently ignored when they shouldn't have
#1127
f08b20eThanks @juliusmarminge! - fix: allow
deeply nested objects when using JsonArray
#1128
e7ccec9Thanks @juliusmarminge! - chore: add new
ufsUrlfield withhttps://APP_ID.ufs.sh/f/FILE_KEYurl. deprecatedurland
appUrlfields.Updated dependencies
[
f08b20e]:@uploadthing/vue@7.2.0
Minor Changes
36b0df6Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e]:@uploadthing/nuxt@7.1.6
Patch Changes
[
36b0df6]:@uploadthing/shared@7.1.6
Patch Changes
f08b20eThanks @juliusmarminge! - fix: allow
deeply nested objects when using JsonArray
Summary by CodeRabbit
New Features
ufsUrlfield for file uploadsBug Fixes
Dependency Updates
Deprecations
urlandappUrlfields in favor of newufsUrl