Skip to content

Conversation

@patrickcping
Copy link
Contributor

@patrickcping patrickcping commented Nov 7, 2025

Change Description

Update linting to be consistent between local and GH actions runs

Waiting for #37 to be merged first, to not surprise Wes with a bunch of lint re-work..

Change Characteristics

  • This PR contains beta functionality
  • This PR requires introduction of breaking changes
  • No changelog entry is needed
  • This PR contains code from the SDK generator process
  • This PR contains written code

Checklist

All full (or complete) PRs that need review prior to merge should have the following box checked.

If contributing a partial or incomplete change (expecting the development team to complete the remaining work) please leave the box unchecked

  • Check to confirm: I have performed a review of my PR against the PR checklist and confirm that:
    • Changes have proper test coverage (including regression tests)
    • Does not introduce breaking changes (unless required to do so)
    • I am aware that changes to generated code may not be merged

Required SDK Upgrades

N/a

Testing

This PR has been tested with:

  • Unit tests (please paste commands and results below)
  • Acceptance tests (please paste commands and results below)
  • End-to-end tests (please paste the link to the actions workflow runs)
  • Not applicable (no evidences needed)

Shell Command(s)

make test

Testing Results

Expand Results
=== RUN   TestNewConfiguration
--- PASS: TestNewConfiguration (0.00s)
=== RUN   TestWithAuthEnvironmentID
--- PASS: TestWithAuthEnvironmentID (0.00s)
=== RUN   TestWithClientID
--- PASS: TestWithClientID (0.00s)
=== RUN   TestWithGrantType
--- PASS: TestWithGrantType (0.00s)
=== RUN   TestWithClientSecret
--- PASS: TestWithClientSecret (0.00s)
=== RUN   TestWithAccessToken
--- PASS: TestWithAccessToken (0.00s)
=== RUN   TestWithTopLevelDomain
--- PASS: TestWithTopLevelDomain (0.00s)
=== RUN   TestWithRootDomain
--- PASS: TestWithRootDomain (0.00s)
=== RUN   TestWithAPIDomain
--- PASS: TestWithAPIDomain (0.00s)
=== RUN   TestWithCustomDomain
--- PASS: TestWithCustomDomain (0.00s)
=== RUN   TestHasBearerToken
=== RUN   TestHasBearerToken/Has_token
=== RUN   TestHasBearerToken/Empty_token
=== RUN   TestHasBearerToken/Nil_token
--- PASS: TestHasBearerToken (0.00s)
    --- PASS: TestHasBearerToken/Has_token (0.00s)
    --- PASS: TestHasBearerToken/Empty_token (0.00s)
    --- PASS: TestHasBearerToken/Nil_token (0.00s)
=== RUN   TestAddBearerTokenToContext
=== RUN   TestAddBearerTokenToContext/Has_token
=== RUN   TestAddBearerTokenToContext/Empty_token
=== RUN   TestAddBearerTokenToContext/Nil_token
--- PASS: TestAddBearerTokenToContext (0.00s)
    --- PASS: TestAddBearerTokenToContext/Has_token (0.00s)
    --- PASS: TestAddBearerTokenToContext/Empty_token (0.00s)
    --- PASS: TestAddBearerTokenToContext/Nil_token (0.00s)
=== RUN   TestBearerToken
--- PASS: TestBearerToken (0.00s)
=== RUN   TestAuthEndpoints
=== RUN   TestAuthEndpoints/With_custom_domain
=== RUN   TestAuthEndpoints/With_environment_ID_and_root_domain
=== RUN   TestAuthEndpoints/With_environment_ID_and_top_level_domain
=== RUN   TestAuthEndpoints/Missing_configuration
--- PASS: TestAuthEndpoints (0.00s)
    --- PASS: TestAuthEndpoints/With_custom_domain (0.00s)
    --- PASS: TestAuthEndpoints/With_environment_ID_and_root_domain (0.00s)
    --- PASS: TestAuthEndpoints/With_environment_ID_and_top_level_domain (0.00s)
    --- PASS: TestAuthEndpoints/Missing_configuration (0.00s)
=== RUN   TestAPIDomain
=== RUN   TestAPIDomain/With_API_domain
=== RUN   TestAPIDomain/With_root_domain
=== RUN   TestAPIDomain/With_top_level_domain
=== RUN   TestAPIDomain/Missing_configuration
--- PASS: TestAPIDomain (0.00s)
    --- PASS: TestAPIDomain/With_API_domain (0.00s)
    --- PASS: TestAPIDomain/With_root_domain (0.00s)
    --- PASS: TestAPIDomain/With_top_level_domain (0.00s)
    --- PASS: TestAPIDomain/Missing_configuration (0.00s)
=== RUN   TestTokenSource
=== RUN   TestTokenSource/With_access_token
=== RUN   TestTokenSource/With_client_credentials_and_client_secret
=== RUN   TestTokenSource/With_client_credentials_missing_client_ID
=== RUN   TestTokenSource/With_client_credentials_missing_client_secret
=== RUN   TestTokenSource/Missing_valid_endpoints
--- PASS: TestTokenSource (0.00s)
    --- PASS: TestTokenSource/With_access_token (0.00s)
    --- PASS: TestTokenSource/With_client_credentials_and_client_secret (0.00s)
    --- PASS: TestTokenSource/With_client_credentials_missing_client_ID (0.00s)
    --- PASS: TestTokenSource/With_client_credentials_missing_client_secret (0.00s)
    --- PASS: TestTokenSource/Missing_valid_endpoints (0.00s)
=== RUN   TestClient
=== RUN   TestClient/Valid_configuration_with_token
=== RUN   TestClient/Invalid_configuration
--- PASS: TestClient (0.00s)
    --- PASS: TestClient/Valid_configuration_with_token (0.00s)
    --- PASS: TestClient/Invalid_configuration (0.00s)
PASS
ok      github.com/pingidentity/pingone-go-client/config        0.634s
=== RUN   TestGrantTypeConstants
--- PASS: TestGrantTypeConstants (0.00s)
=== RUN   TestTokenAuthTypeConstants
--- PASS: TestTokenAuthTypeConstants (0.00s)
=== RUN   TestAllowedTokenAuthMethods
--- PASS: TestAllowedTokenAuthMethods (0.00s)
PASS
ok      github.com/pingidentity/pingone-go-client/oauth2        0.477s
=== RUN   TestPingOneEndpoint
--- PASS: TestPingOneEndpoint (0.00s)
=== RUN   TestPingOneEnvironmentEndpoint
=== RUN   TestPingOneEnvironmentEndpoint/Valid_root_domain_and_environment_ID
=== RUN   TestPingOneEnvironmentEndpoint/Root_domain_with_leading_dot
=== RUN   TestPingOneEnvironmentEndpoint/Empty_environment_ID
--- PASS: TestPingOneEnvironmentEndpoint (0.00s)
    --- PASS: TestPingOneEnvironmentEndpoint/Valid_root_domain_and_environment_ID (0.00s)
    --- PASS: TestPingOneEnvironmentEndpoint/Root_domain_with_leading_dot (0.00s)
    --- PASS: TestPingOneEnvironmentEndpoint/Empty_environment_ID (0.00s)
=== RUN   TestPingOneExtendedEndpoint
--- PASS: TestPingOneExtendedEndpoint (0.00s)
=== RUN   TestPingOneEnvironmentExtendedEndpoint
=== RUN   TestPingOneEnvironmentExtendedEndpoint/Valid_root_domain_and_environment_ID
=== RUN   TestPingOneEnvironmentExtendedEndpoint/Root_domain_with_leading_dot
=== RUN   TestPingOneEnvironmentExtendedEndpoint/Empty_environment_ID
--- PASS: TestPingOneEnvironmentExtendedEndpoint (0.00s)
    --- PASS: TestPingOneEnvironmentExtendedEndpoint/Valid_root_domain_and_environment_ID (0.00s)
    --- PASS: TestPingOneEnvironmentExtendedEndpoint/Root_domain_with_leading_dot (0.00s)
    --- PASS: TestPingOneEnvironmentExtendedEndpoint/Empty_environment_ID (0.00s)
=== RUN   TestConstantPaths
--- PASS: TestConstantPaths (0.00s)
PASS
ok      github.com/pingidentity/pingone-go-client/oauth2/endpoints      0.341s
=== RUN   TestPingOneOIDCEndpoint
--- PASS: TestPingOneOIDCEndpoint (0.00s)
=== RUN   TestPingOneEnvironmentOIDCEndpoint
=== RUN   TestPingOneEnvironmentOIDCEndpoint/Valid_root_domain_and_environment_ID
=== RUN   TestPingOneEnvironmentOIDCEndpoint/Root_domain_with_leading_dot
=== RUN   TestPingOneEnvironmentOIDCEndpoint/Empty_environment_ID
--- PASS: TestPingOneEnvironmentOIDCEndpoint (0.00s)
    --- PASS: TestPingOneEnvironmentOIDCEndpoint/Valid_root_domain_and_environment_ID (0.00s)
    --- PASS: TestPingOneEnvironmentOIDCEndpoint/Root_domain_with_leading_dot (0.00s)
    --- PASS: TestPingOneEnvironmentOIDCEndpoint/Empty_environment_ID (0.00s)
=== RUN   TestConstantPaths
--- PASS: TestConstantPaths (0.00s)
PASS
ok      github.com/pingidentity/pingone-go-client/oidc/endpoints        0.211s

End-to-end Tests Workflow Links

@patrickcping patrickcping changed the title Update linting for local and GitHub actions @patrickcping Update linting for local and GitHub actions Nov 7, 2025
@patrickcping patrickcping changed the title Update linting for local and GitHub actions Housekeeping: Update linting for local and GitHub actions Nov 7, 2025
@patrickcping patrickcping self-assigned this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants