Initial addition of new Kafka consumer #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my inital stab at creating a clojure wrapper for the new 0.9 Kafka consumer. Whilst there's still some cleanup and re-organisation to do, I would really appreciate any review/feedback on how improve things.
From a user point of view, I think it would be useful to have the messages function have the option to subscribe and consume messages. This refactor covers what I believe are the most common/needed use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my initial stab at creating a clojure wrapper for the
new 0.9 Kafka consumer.
Whilst there's still some cleanup and re-organisation to do,
I would really appreciate any review/feedback on how to improve things.
--Dayo