Releasey workflow review #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
commented
Nov 8, 2025
|
|
||
| - name: Import GPG key | ||
| uses: crazy-max/ghaction-import-gpg@v6 | ||
| uses: crazy-max/ghaction-import-gpg@e89d40939c28e39f97cf32126055eeae86ba74ec # v6.3.0 |
Author
There was a problem hiding this comment.
Must only use use hash-references (see Actions Policy
And also only use action+version that are allowed by the policy, currently approved patterns are here
| local current_version_with_dash | ||
| local version_with_dash | ||
| current_version_with_dash="$(echo "${old_version//-/--}")" | ||
| version_with_dash="$(echo "$version//-/--}")" |
snazy
force-pushed
the
releasey-workflow-review
branch
from
af380c5 to
f65458d
Compare
pingtimeout
reviewed
Nov 10, 2025
| username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN }} | ||
| run: | | ||
| echo "${{ secrets.DOCKERHUB_TOKEN }}" | docker login ghcr.io -u "${{ secrets.DOCKERHUB_USERNAME }}" --password-stdin |
Owner
There was a problem hiding this comment.
IIUC this is required because the docker/login-action Github Action is not in approved_patterns.yml ?
| current_version_with_dash="$(echo "${old_version//-/--}")" | ||
| version_with_dash="$(echo "$version//-/--}")" | ||
| exec_process sed -i~ "s/${current_version_with_dash}/${version_with_dash}/" "$HELM_README_FILE" | ||
| current_version_with_dash="${old_version//-/--}" |
Owner
There was a problem hiding this comment.
This line is not needed anymore, is it?
Author
There was a problem hiding this comment.
Correct, feel free to remove it ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.