-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make APIs better #271
Merged
Merged
Make APIs better #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also took the time to make signalling version agnostic internally so I'm not importing API definitions outside of the signal api file
Now with release binds and bind modes!
It's not that ergonomic and you can use signals to achieve the same thing. Also kanshi exists
Is now imperative and you use the same methods on windows as everywhere else
Removes the re-export of the snowcap api because it's not stable
And remove old proto api defs
Ayo we need tests where are the tests please we should write some tests
oh how I hate how Lua is 1-indexed
All xwayland windows after the first would have keyboard focus upon open but not actually pass through key presses until the keyboard focus changed
Still doesn't run cuz we're running out of wayland sockets for some reason
Closes #138 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well my right middle finger's knuckle is still sore from no-lifeing Celeste so I decided to work on this thing insteadwe are so back babyThis PR is intended to be the big final breaking change to the Lua and Rust APIs until 0.1 is released. As a result, this PR is going to be way too big and cover the following aspects:
std::process::Command
awful.spawn.once
so you can spawn things on startup, close them, and not have them respawn on config reloadAnd remember to do that "let xwayland scale itself" thingpushing off to laterSide note: I regret deciding to do a Rust API because wow is it not fun to try to design something remotely ergonomic hahanvm this is kinda funEdit: hey past me it's present me here to tell you to:
Add docs for the move from metaconfig.toml to pinnacle.tomlAdd docs for the new input API