Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CJS default export in types #76

Merged
merged 2 commits into from
Sep 4, 2023
Merged

fix CJS default export in types #76

merged 2 commits into from
Sep 4, 2023

Conversation

FabianFrank
Copy link
Contributor

fixes #71

opts: EnablePipelining
): Transform;

export { OnUnknown };
declare namespace build {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declaring a namespace and merging the interface onto it is what prevents this from making a backwards breaking change, i.e. import build, { OnUnknown } from "pino-abstract-transport" still works.

@FabianFrank
Copy link
Contributor Author

FabianFrank commented Sep 2, 2023

FYI the npm install error in CI / Test (14, windows-latest) appears unrelated to my changes:

npm ERR! code EPERM
npm ERR! syscall rename
npm ERR! path D:\a\pino-abstract-transport\pino-abstract-transport\node_modules\tap\node_modules\@jridgewell\.trace-mapping.DELETE\node_modules\@jridgewell
npm ERR! dest D:\a\pino-abstract-transport\pino-abstract-transport\node_modules\tap\node_modules\@jridgewell\trace-mapping\node_modules\@jridgewell
npm ERR! errno -4048

Maybe just requires a re-run?

@mcollina
Copy link
Member

mcollina commented Sep 3, 2023

Could you add an exclude in the actions for windows/node v14? It's broken in gha beyond repair.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2104c0c into pinojs:main Sep 4, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript: build is not callable
2 participants