Updating for v9: update dependencies and CI

[Ranieri93]

Hello everyone!

This PR is referencing this issue.

Quick question, should I leave "pino-std-serializers": "^6.0.0" like this? Or do we expect a major release after the update for v9?

Thank you in advance!

@jsumners

[jsumners]

Quick question, should I leave "pino-std-serializers": "^6.0.0" like this? Or do we expect a major release after the update for v9?

We will not be able to release new versions of ecosystem modules until pino@9 is ready to be released. The updated ecosystem modules will be remain on their respective next branches until that time (see https://github.com/orgs/pinojs/projects/1). Any modules that have dependencies on each other should use git URLs to specify the dependencies until we are ready to publish actual versions.

[Ranieri93]

Quick question, should I leave "pino-std-serializers": "^6.0.0" like this? Or do we expect a major release after the update for v9?

We will not be able to release new versions of ecosystem modules until pino@9 is ready to be released. The updated ecosystem modules will be remain on their respective next branches until that time (see https://github.com/orgs/pinojs/projects/1). Any modules that have dependencies on each other should use git URLs to specify the dependencies until we are ready to publish actual versions.

I never used such a syntax, I researched a little bit and I hope this is the correct one, but correct me if I'm wrong!

Also, this is probably a stupid question but:
I'm seeing tests failing on node 20 because the coverage threshold is not met, what should be done in this case?
Because test response comes always with different uncovered line numbers, I'm a bit confused!

Thank you in advance as always for your response!

[jsumners]

The primary issue is that this test is failing under Node 20:

pino-http/test/test.js

Lines 477 to 517 in 9bf0802

	test('log requests aborted during payload', function (t) {
	const dest = split(JSON.parse)
	const logger = pinoHttp(dest)
	function handle (req, res) {
	logger(req, res)
	const read = new stream.Readable({
	read () {
	if (this.called) {
	return
	}
	this.called = true
	this.push('delayed')
	}
	})
	read.pipe(res)
	}
	function listen (err, server) {
	t.error(err)
	const client = net.connect(server.address().port, server.address().address, () => {
	client.write('GET /delayed HTTP/1.1\r\n\r\n')
	})
	client.on('data', (data) => {
	client.destroy()
	})
	}
	setup(t, logger, listen, handle)
	dest.on('data', function (line) {
	t.ok(line.responseTime >= 0, 'responseTime is defined')
	t.equal(line.msg, DEFAULT_REQUEST_ABORTED_MSG, 'message is set')
	t.end()
	})
	})

It's not clear to me why. I reduced the issue down to the following script that works correctly under Node 18 but returns a 400 response under node 20:

'use strict'

const http = require('http')
const net = require('net')

const server = http.createServer(function (req, res) {
  res.statusCode = 200
  res.end('ok')
})

server.listen(0, '127.0.0.1', function (err) {
  if (err) {
    console.error(err)
    server.close()
    return
  }

  const client = net.connect(server.address().port, '127.0.0.1', () => {
    client.write('GET /delayed HTTP/1.1\r\n\r\n')
  })

  client.on('data', (data) => {
    console.log('data: ', data.toString())
    client.destroy()
    server.close()
  })
})

@mcollina any ideas here?

[jsumners]

@Ranieri93 you should be able to rebase now to get passing tests.

[jsumners]

Looks good to me.