Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from chalk to colorette #208

Closed
kibertoad opened this issue Jul 16, 2021 · 5 comments · Fixed by #218
Closed

Switch from chalk to colorette #208

kibertoad opened this issue Jul 16, 2021 · 5 comments · Fixed by #218

Comments

@kibertoad
Copy link
Contributor

See https://www.npmjs.com/package/colorette
2x faster, cleaner implementation, zero dependencies.

If there is an approval, I can give it a shot. Migration for knex was really straightforward back in the day: knex/knex#2718

@mcollina
Copy link
Member

Sure, it seems also to ship a cjs version. go ahead!

@kibertoad
Copy link
Contributor Author

Currently blocked by jorgebucaran/colorette#61

@mcollina
Copy link
Member

mcollina commented Aug 1, 2021

I'm ok for that code to be part of pino-pretty if you prefer.

@kibertoad
Copy link
Contributor Author

kibertoad commented Aug 2, 2021

@mcollina Generally I would prefer to see this functionality upstream, the only reason why it might be preferable to have it in pino-pretty is being able to lock to slightly older version to avoid stumbling upon jorgebucaran/colorette#48. Do we officially support older Node 13 versions?

@mcollina
Copy link
Member

mcollina commented Aug 2, 2021

I'm ok to bump minimum Node.js to v12.x, v14.x and v16.x all at their latest.

We'll bump the major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants