Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CI environments is lacking #61

Closed
kibertoad opened this issue Aug 1, 2021 · 7 comments · Fixed by #62
Closed

Support for CI environments is lacking #61

kibertoad opened this issue Aug 1, 2021 · 7 comments · Fixed by #62
Labels
enhancement New feature or request

Comments

@kibertoad
Copy link
Collaborator

kibertoad commented Aug 1, 2021

Current implementation doesn't reliably determine colour support in CI environments, resulting e. g. in CI for https://github.com/pinojs/pino-pretty/tree/feat/colorette breaking.

I think these lines from supports-colour should be included:

	if ('CI' in env) {
		if (['TRAVIS', 'CIRCLECI', 'APPVEYOR', 'GITLAB_CI', 'GITHUB_ACTIONS', 'BUILDKITE', 'DRONE'].some(sign => sign in env) || env.CI_NAME === 'codeship') {
			return 1;
		}

		return min;
	}
@kibertoad
Copy link
Collaborator Author

@jorgebucaran Would you accept a PR for this?

@jorgebucaran
Copy link
Owner

Of course. Do you think we can simplify this expression to check for only the main services (GitHub, CircleCI)?

@kibertoad
Copy link
Collaborator Author

@jorgebucaran Sure, although I would also include GitLab there, lots of major players are using it.

@jorgebucaran
Copy link
Owner

Makes sense. 👌

@kibertoad
Copy link
Collaborator Author

@jorgebucaran Any chance you could publish a new version?

@jorgebucaran
Copy link
Owner

Yes, sorry, will do! 🙇‍♂️

@jorgebucaran
Copy link
Owner

Published as @1.3.0. I didn't include #60 because it doesn't really block you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants