-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for CI environments is lacking #61
Comments
@jorgebucaran Would you accept a PR for this? |
Of course. Do you think we can simplify this expression to check for only the main services (GitHub, CircleCI)? |
@jorgebucaran Sure, although I would also include GitLab there, lots of major players are using it. |
Makes sense. 👌 |
@jorgebucaran Any chance you could publish a new version? |
Yes, sorry, will do! 🙇♂️ |
Published as @1.3.0. I didn't include #60 because it doesn't really block you. |
Current implementation doesn't reliably determine colour support in CI environments, resulting e. g. in CI for https://github.com/pinojs/pino-pretty/tree/feat/colorette breaking.
I think these lines from
supports-colour
should be included:The text was updated successfully, but these errors were encountered: