Check if process is defined for better browser compatibility

[RomanHotsiy]

Added a little extra check to prevent process is not defined error when the library is included in the browser build by webpack 5.

[jorgebucaran]

Thanks, @RomanHotsiy. Mind explaining why we need that to work?

[RomanHotsiy]

Sure, @jorgebucaran.

I use this library in a package that can be used in node and browser. Most users of the lib use Webpack for browser bundles. Webpack 4 automatically included process polyfill which is not the case for Webpack 5 anymore.

So the code fails in runtime: 'process is not defined'. This can be fixed in Webpack config itself but it complicates the setup for every user.

This change adds a simple check if the process variable is defined. It doesn't change anything for node env but does not crash in browsers or other envs where the process may be not definied.

[jorgebucaran]

Thanks for the explanation, @RomanHotsiy.

[kibertoad]

@jorgebucaran Do you think this change should be included? I can rebase it if you want.

[jorgebucaran]

I've been so used to using the global process object I had forgotten we could import it.

Wouldn't it be better to import { env, platform } from "process"?

[kibertoad]

@jorgebucaran does that work with CJS require as well? if yes, that would be simpler, yes.

[jorgebucaran]

Yes. We just need to change how index.cjs is currently compiled to CommonJS.

What's Pino's deprecation roadmap for CommonJS, by the way?

[kibertoad]

@jorgebucaran Yes, likely late 2022, after LTS lands.

[jorgebucaran]

Nice. Exciting times ahead! 💯

[jorgebucaran]

I might've fixed this with cf35254. Please have a look. Now available in 2.0.4.