Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript declarations missing destination option #300

Closed
CoeJoder opened this issue Jan 26, 2022 · 2 comments · Fixed by #308
Closed

TypeScript declarations missing destination option #300

CoeJoder opened this issue Jan 26, 2022 · 2 comments · Fixed by #308
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@CoeJoder
Copy link
Contributor

In index.d.ts the PrettyOptions_ interface is missing the destination property.
@mcollina
Copy link
Member

Would you like to send a Pull Request to address this issue? Remember to add unit tests. We use tsd.

@mcollina mcollina added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 27, 2022
@CoeJoder
Copy link
Contributor Author

Yes I will submit a PR probably later this week when I have time, if not already done by someone else.

@CoeJoder CoeJoder mentioned this issue Feb 26, 2022
Merged
mcollina pushed a commit that referenced this issue Feb 26, 2022
@CoeJoder
Add missing TypeScript declarations (#300) (#308)
e9efbd7
mcollina pushed a commit that referenced this issue Feb 27, 2022
@CoeJoder
Add missing type test for #300 (#309)
3cc0605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing TypeScript declarations (#300)
2 participants
@mcollina @CoeJoder