Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow sonic-boom to filter call to close on stdout #280

Merged
merged 2 commits into from
Dec 8, 2021
Merged

allow sonic-boom to filter call to close on stdout #280

merged 2 commits into from
Dec 8, 2021

Conversation

mojavelinux
Copy link
Contributor

closes #279

@mojavelinux
Copy link
Contributor Author

I split this PR into two commits. The first commit asserts the existing functionality. Then, the second commit builds on that to verify that the original assertion still works and the messages are flushed when end() is called on the destination.

mcollina
mcollina approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit eb88841 into pinojs:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pino-pretty breaks flushing of stdout
2 participants
@mojavelinux @mcollina