Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom prettifiers on the metadata #283

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

airhorns
Copy link
Contributor

So folks can prettify the pid, logger name, or hostname as they see fit!

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

CI is failing

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation showing how to use this feature.

lib/utils.js Show resolved Hide resolved
@airhorns airhorns force-pushed the more-custom-prettifiers branch 3 times, most recently from ac9b32a to a7520cf Compare December 13, 2021 20:33
@airhorns
Copy link
Contributor Author

Updated with docs and the coverage target

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Dec 14, 2021

Pull Request Test Coverage Report for Build 1578713588

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1573904585: 0.0%
Covered Lines: 318
Relevant Lines: 318

💛 - Coveralls

lib/utils.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
So folks can prettify the pid, logger name, or hostname as they see fit
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mcollina mcollina merged commit 96fcc9b into pinojs:master Dec 14, 2021
@airhorns airhorns deleted the more-custom-prettifiers branch December 14, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants